Received: by oss.sgi.com id ; Sun, 18 Jun 2000 07:40:26 -0700 Received: from pizda.ninka.net ([216.101.162.242]:56978 "EHLO pizda.ninka.net") by oss.sgi.com with ESMTP id ; Sun, 18 Jun 2000 07:39:50 -0700 Received: (from davem@localhost) by pizda.ninka.net (8.9.3/8.9.3) id HAA04840; Sun, 18 Jun 2000 07:26:13 -0700 Date: Sun, 18 Jun 2000 07:26:13 -0700 Message-Id: <200006181426.HAA04840@pizda.ninka.net> X-Authentication-Warning: pizda.ninka.net: davem set sender to davem@redhat.com using -f From: "David S. Miller" To: andrewm@uow.edu.au CC: netdev@oss.sgi.com, alan@redhat.com, kuznet@ms2.inr.ac.ru In-reply-to: <394CD00E.A02FEBBE@uow.edu.au> (message from Andrew Morton on Sun, 18 Jun 2000 23:35:10 +1000) Subject: Re: [patch] TCP throughput after 2.2.17-pre1 References: <394CD00E.A02FEBBE@uow.edu.au> Sender: owner-netdev@oss.sgi.com Precedence: bulk Return-Path: X-Orcpt: rfc822;netdev-outgoing Date: Sun, 18 Jun 2000 23:35:10 +1000 From: Andrew Morton The problem is caused by this patch: The change aparently came from Alexey to cure some deadlock issues. I just noticed the change today, and I also am skeptical about it's correctness. It I understand correctly, it's the simple issue about the lack of distinction between a socket buffer allocation failing because of going over the socket limits or a real kmalloc failure of some sort. Someone needs to sort this out correctly and I'd like to ask Alan to back this out until a better fix is found. Later, David S. Miller davem@redhat.com