From:   Alan Cox <alan@redhat.com>
Message-Id: <200006181447.KAA07398@devserv.devel.redhat.com>
Subject: Re: [patch] TCP throughput after 2.2.17-pre1
To:     davem@redhat.com (David S. Miller)
Date:   Sun, 18 Jun 2000 10:47:01 -0400 (EDT)
Cc:     andrewm@uow.edu.au, netdev@oss.sgi.com, alan@redhat.com,
        kuznet@ms2.inr.ac.ru
In-Reply-To: <200006181426.HAA04840@pizda.ninka.net> from "David S. Miller" at Jun 18, 2000 07:26:13 AM
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-netdev@oss.sgi.com
Precedence: bulk

> The change aparently came from Alexey to cure some
> deadlock issues.

Its from me.  Its critical to fix the problem

> Someone needs to sort this out correctly and I'd like to ask
> Alan to back this out until a better fix is found.

Its fixed a huge range of hangs especially on SMP boxes. Its staying until
the proper fix is done. That probably needs a sock_wmalloc_err() and also
the new code path waking on the socket kfreeing a buffer.

Right at the moment its a huge win having it in 2.2.17pre because I can 
actually look at the few remaining 'it hung' reports and work on those. 2.2.17
we have to fix this properly - neither the hack fix nor ignoring it are
options.

Alan