Received:  by oss.sgi.com id <S42315AbQFTMDf>;
	Tue, 20 Jun 2000 05:03:35 -0700
Received: from [203.126.247.144] ([203.126.247.144]:8429 "EHLO zsngs001")
	by oss.sgi.com with ESMTP id <S42229AbQFTMDG>;
	Tue, 20 Jun 2000 05:03:06 -0700
Received: from zsngd101.asiapac.nortel.com (actually znsgd101) by zsngs001;
          Tue, 20 Jun 2000 20:02:42 +0800
Received: from zctwb003.asiapac.nortel.com ([47.152.32.111]) 
          by zsngd101.asiapac.nortel.com 
          with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2650.21) 
          id NBKHBTN6; Tue, 20 Jun 2000 20:02:45 +0800
Received: from pwold011.asiapac.nortel.com ([47.181.193.45]) 
          by zctwb003.asiapac.nortel.com 
          with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2650.21) 
          id NCLF8CPQ; Tue, 20 Jun 2000 22:02:48 +1000
Received: from uow.edu.au (IDENT:akpm@[47.181.194.130]) 
          by pwold011.asiapac.nortel.com (8.9.3/8.9.3) with ESMTP id WAA18430;
          Tue, 20 Jun 2000 22:02:29 +1000
Message-ID: <394F5E62.DE02F835@uow.edu.au>
Date:   Tue, 20 Jun 2000 22:06:58 +1000
X-Sybari-Space: 00000000 00000000 00000000
From:   Andrew Morton <andrewm@uow.edu.au>
X-Mailer: Mozilla 4.7 [en] (X11; I; Linux 2.2.14-15mdk i586)
X-Accept-Language: en
MIME-Version: 1.0
To:     Andi Kleen <ak@muc.de>
CC:     Keith Owens <kaos@ocs.com.au>, Donald Becker <becker@scyld.com>,
        "netdev@oss.sgi.com" <netdev@oss.sgi.com>
Subject: Re: modular net drivers, take 2
References: <Pine.LNX.4.10.10006192011230.26261-100000@vaio.greennet> <3292.961460999@kao2.melbourne.sgi.com> <20000620124146.A1375@fred.muc.de>,
            <20000620124146.A1375@fred.muc.de>; from Andi Kleen on Tue, Jun 20,
            2000 at 12:41:46PM +0200 <20000620124613.A1833@fred.muc.de>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Orig: <andrewm@uow.edu.au>
Sender: owner-netdev@oss.sgi.com
Precedence: bulk
Return-Path: <owner-netdev@oss.sgi.com>
X-Orcpt: rfc822;netdev-outgoing

Andi Kleen wrote:
> 
> 
> Ok, there is still a small race with the actual module unload. I think
> the cleanest solution is to let open/close run in the big kernel lock.
> They are not performance critical anyways.
> 
> Comments ?

- devinet_ioctl() calls dev_change_flags() direct, thus
  neatly bypassing your lock_kernel() :(

- sys_ioctl() and sys_delete_module() both already claim
  the big lock, so where's the race anyway?  I feel I'm missing
  something..