Received:  by oss.sgi.com id <S42212AbQFYQts>;
	Sun, 25 Jun 2000 09:49:48 -0700
Received: from iwr1.iwr.uni-heidelberg.de ([129.206.104.40]:31651 "EHLO
        iwr1.iwr.uni-heidelberg.de") by oss.sgi.com with ESMTP
	id <S42183AbQFYQtX>; Sun, 25 Jun 2000 09:49:23 -0700
Received: from kenzo.iwr.uni-heidelberg.de (IDENT:bogdan@kenzo.iwr.uni-heidelberg.de [129.206.120.29])
	by iwr1.iwr.uni-heidelberg.de (8.9.3/8.9.3) with ESMTP id SAA25119;
	Sun, 25 Jun 2000 18:48:52 +0200 (MET DST)
Received: from localhost (bogdan@localhost)
	by kenzo.iwr.uni-heidelberg.de (8.8.7/8.8.7) with ESMTP id SAA25940;
	Sun, 25 Jun 2000 18:48:51 +0200
Date:   Sun, 25 Jun 2000 18:48:51 +0200 (CEST)
From:   Bogdan Costescu <Bogdan.Costescu@IWR.Uni-Heidelberg.De>
To:     Alan Cox <alan@lxorguk.ukuu.org.uk>
cc:     Andrew Morton <andrewm@uow.edu.au>,
        "netdev@oss.sgi.com" <netdev@oss.sgi.com>,
        Andreas Tobler <toa@pop.agri.ch>
Subject: Re: [patch] 3c59x.c for 2.2.17
In-Reply-To: <E136EHC-0002Xn-00@the-village.bc.nu>
Message-ID: <Pine.LNX.4.10.10006251820560.25793-100000@kenzo.iwr.uni-heidelberg.de>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-netdev@oss.sgi.com
Precedence: bulk
Return-Path: <owner-netdev@oss.sgi.com>
X-Orcpt: rfc822;netdev-outgoing


On Sun, 25 Jun 2000, Alan Cox wrote:

> No. I want to do

With all due respect, I don't understand!

> 	if(<copybreak)
> 	{
> 		skb=alloc_skb(RING_SIZE);

What has RING_SIZE to do with the allocation of a buffer? Should it be
"PKT_BUF_SZ" instead (="size of each temporary Rx buffer") ?

> 		if(skb==NULL)
> 			recycle original

What does "recycle" mean: is it sent up or kept? In case it's sent up, how
do we get another buffer? In case it's kept, what do we send?

> 	}
> 	else
> 	{
> 		alloc skb
> 		if(skb!=NULL)
> 			copy
> 	}

Now the "else" part is just the opposite of Don's copybreak scheme. Why
do you want to copy when pkt_size > rx_copybreak? Isn't memcpy too
expensive in this case?

Sincerely,

Bogdan Costescu

IWR - Interdisziplinaeres Zentrum fuer Wissenschaftliches Rechnen
Universitaet Heidelberg, INF 368, D-69120 Heidelberg, GERMANY
Telephone: +49 6221 54 8869, Telefax: +49 6221 54 8868
E-mail: Bogdan.Costescu@IWR.Uni-Heidelberg.De