Received: with ECARTIS (v1.0.0; list netdev); Thu, 17 Oct 2002 15:32:36 -0700 (PDT)
Received: from pizda.ninka.net (IDENT:root@pizda.ninka.net [216.101.162.242])
	by oss.sgi.com (8.12.5/8.12.5) with SMTP id g9HMWWtG021676
	for <netdev@oss.sgi.com>; Thu, 17 Oct 2002 15:32:32 -0700
Received: from localhost (IDENT:davem@localhost.localdomain [127.0.0.1])
	by pizda.ninka.net (8.9.3/8.9.3) with ESMTP id PAA02339;
	Thu, 17 Oct 2002 15:24:53 -0700
Date: Thu, 17 Oct 2002 15:24:52 -0700 (PDT)
Message-Id: <20021017.152452.43031634.davem@redhat.com>
To: niv@us.ibm.com
Cc: netdev@oss.sgi.com
Subject: Re: [Patch 2.5.43] IpInDelivers, IpInDiscards
From: "David S. Miller" <davem@redhat.com>
In-Reply-To: <Pine.LNX.4.44.0210171428520.3131-100000@w-nivedita.beaverton.ibm.com>
References: <Pine.LNX.4.44.0210171428520.3131-100000@w-nivedita.beaverton.ibm.com>
X-FalunGong: Information control.
X-Mailer: Mew version 2.1 on Emacs 21.1 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-archive-position: 758
X-ecartis-version: Ecartis v1.0.0
Sender: netdev-bounce@oss.sgi.com
Errors-to: netdev-bounce@oss.sgi.com
X-original-sender: davem@redhat.com
Precedence: bulk
X-list: netdev


   From: Nivedita Singhvi <niv@us.ibm.com>
   Date: Thu, 17 Oct 2002 14:49:04 -0700 (PDT)

   This patch cleans up the use of the SNMP stats counters
   IpInDelivers and IpInDiscards (and the v6 counterparts). 
   A patch to address some of this had been submitted a while 
   ago by Mark Price.

I agree with with.  I just have some minor troubles with some of
the changes to ip_input.c

Specifically, the ip_rcv_finish() and ip_rcv() counter bumps
should all move to right below the drop: label which exists in
both functions.

Make this fixup, and I'll apply the patch.

Thanks.