Received: with ECARTIS (v1.0.0; list netdev); Tue, 29 Apr 2003 00:06:57 -0700 (PDT) Received: from pizda.ninka.net (IDENT:root@pizda.ninka.net [216.101.162.242]) by oss.sgi.com (8.12.9/8.12.9) with SMTP id h3T76nFu020036 for ; Tue, 29 Apr 2003 00:06:49 -0700 Received: from localhost (IDENT:davem@localhost.localdomain [127.0.0.1]) by pizda.ninka.net (8.9.3/8.9.3) with ESMTP id XAA26621; Mon, 28 Apr 2003 23:00:34 -0700 Date: Mon, 28 Apr 2003 23:00:34 -0700 (PDT) Message-Id: <20030428.230034.08345606.davem@redhat.com> To: acme@conectiva.com.br Cc: mostrows@speakeasy.net, netdev@oss.sgi.com, maxk@qualcomm.com Subject: Re: [PATCH] af_pppox: create module infrastructure for protocol modules From: "David S. Miller" In-Reply-To: <20030429065419.GN25361@conectiva.com.br> References: <20030429061227.GJ25361@conectiva.com.br> <20030428.222728.48508327.davem@redhat.com> <20030429065419.GN25361@conectiva.com.br> X-FalunGong: Information control. X-Mailer: Mew version 2.1 on Emacs 21.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp) X-archive-position: 2334 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: davem@redhat.com Precedence: bulk X-list: netdev From: Arnaldo Carvalho de Melo Date: Tue, 29 Apr 2003 03:54:19 -0300 Em Mon, Apr 28, 2003 at 10:27:28PM -0700, David S. Miller escreveu: > Although the idea is conceptually sound, you miss one crucial thing. > Such struct sock's reference _TWO_ modules, the "PPPOE" module > and the "PPPOX" module. But what is the problem? at pppox_sk_alloc time I bump the PPPOE module refcnt, making it safe, then it calls sk_alloc where it bumps the PPPOX module, making it safe as well, so I'm taking care of both PPPOE and PPPOX. You're absolutely correct, I missed this. I'll pull your changes, thanks.