Received: with ECARTIS (v1.0.0; list netdev); Tue, 07 Oct 2003 06:50:25 -0700 (PDT)
Received: from lists.samba.org (dp.samba.org [66.70.73.150])
	by oss.sgi.com (8.12.10/8.12.10) with SMTP id h97DnW25016291
	for <netdev@oss.sgi.com>; Tue, 7 Oct 2003 06:49:52 -0700
Received: by lists.samba.org (Postfix, from userid 590)
	id CA9662C7A8; Tue,  7 Oct 2003 13:49:31 +0000 (GMT)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Julian Anastasov <ja@ssi.bg>
Cc: "David S. Miller" <davem@redhat.com>, Wensong Zhang <wensong@linux-vs.org>,
        netdev@oss.sgi.com
Subject: Re: [2.6 PATCH] ipvs - remove some unused fields from the protocols 
In-reply-to: Your message of "Tue, 07 Oct 2003 01:16:36 +0300."
             <Pine.LNX.4.44.0310070104470.6107-100000@u.domain.uli> 
Date: Tue, 07 Oct 2003 20:14:25 +1000
Message-Id: <20031007134931.CA9662C7A8@lists.samba.org>
X-archive-position: 591
X-ecartis-version: Ecartis v1.0.0
Sender: netdev-bounce@oss.sgi.com
Errors-to: netdev-bounce@oss.sgi.com
X-original-sender: rusty@rustcorp.com.au
Precedence: bulk
X-list: netdev

In message <Pine.LNX.4.44.0310070104470.6107-100000@u.domain.uli> you write:
> 
> 	Hello,
> 
> 	The promised removal of some unused fields. For inclusion after 
> comments from Rusty. Rusty, it seems we can not convert the transmitters 
> to NF_STOLEN, ip_vs_null_xmit returns NF_ACCEPT.

Ah that's right.  I hit that as I was halfway through changing, and
reverted.  Sorry.

Leaving the comment there and adding one in ip_vs_null_xmit on why
breaking the rule in that case is OK is the right approach, I think.

Patch looks good!

Thanks,
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.