Received: with ECARTIS (v1.0.0; list netdev); Wed, 31 Mar 2004 09:30:26 -0800 (PST) Received: from ns1.wanfear.com (ns1.wanfear.com [207.212.57.1]) by oss.sgi.com (8.12.10/8.12.9) with SMTP id i2VHU7KO012676 for ; Wed, 31 Mar 2004 09:30:07 -0800 Received: from candelatech.com (evrtwa1-ar2-4-35-049-074.evrtwa1.dsl-verizon.net [4.35.49.74]) (authenticated bits=0) by ns1.wanfear.com (8.12.10/8.12.10) with ESMTP id i2VHU2PR028651; Wed, 31 Mar 2004 09:30:03 -0800 Message-ID: <406B001A.1030901@candelatech.com> Date: Wed, 31 Mar 2004 09:30:02 -0800 From: Ben Greear Organization: Candela Technologies User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andi Kleen CC: Ville Nuorvala , netdev@oss.sgi.com Subject: Re: [PATCH] Avoid gettimeofday when not needed References: <200403311201.i2VC13D19579@zero.aec.at> <20040331135449.GB62402@colin2.muc.de> <20040331151047.GA6033@colin2.muc.de> In-Reply-To: <20040331151047.GA6033@colin2.muc.de> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-archive-position: 4385 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: greearb@candelatech.com Precedence: bulk X-list: netdev Content-Length: 788 Lines: 27 Andi Kleen wrote: > On Wed, Mar 31, 2004 at 05:24:47PM +0300, Ville Nuorvala wrote: > >>There just doesn't seem to be any general flag field in sk_buff that we >>might use at this moment. Should one be added, or should we just hide the >>flag inside the cb field using the likes of inet_skb_parm and >>inet6_skb_parm? > > > There are no free bits indeed. I think ->cb is the best choice then. Why not add a 32-bit field to the skb to handle various flag needs going forward? If space is very important, could use an uint16 for flags and consolidate the ip_summed and cloned fields, which seem to be boolean fields. unsigned char local_df, cloned, pkt_type, ip_summed; Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com