Received: with ECARTIS (v1.0.0; list netdev); Sun, 12 Sep 2004 17:05:28 -0700 (PDT)
Received: from cheetah.davemloft.net (mail@adsl-63-197-226-105.dsl.snfc21.pacbell.net [63.197.226.105])
	by oss.sgi.com (8.13.0/8.13.0) with ESMTP id i8D05MU7008728
	for <netdev@oss.sgi.com>; Sun, 12 Sep 2004 17:05:22 -0700
Received: from localhost
	([127.0.0.1] helo=cheetah.davemloft.net ident=davem)
	by cheetah.davemloft.net with smtp (Exim 3.36 #1 (Debian))
	id 1C6eJX-00021s-00; Sun, 12 Sep 2004 17:03:23 -0700
Date: Sun, 12 Sep 2004 17:03:23 -0700
From: "David S. Miller" <davem@davemloft.net>
To: Julian Anastasov <ja@ssi.bg>
Cc: laforge@netfilter.org, netdev@oss.sgi.com, rusty@rustcorp.com.au
Subject: Re: [PATCH 2.6] ip_nat_ftp - manip at the right place
Message-Id: <20040912170323.65eadc38.davem@davemloft.net>
In-Reply-To: <Pine.LNX.4.58.0409111042580.1315@u.domain.uli>
References: <Pine.LNX.4.58.0409111042580.1315@u.domain.uli>
X-Mailer: Sylpheed version 0.9.12 (GTK+ 1.2.10; sparc-unknown-linux-gnu)
X-Face: "_;p5u5aPsO,_Vsx"^v-pEq09'CU4&Dc1$fQExov$62l60cgCc%FnIwD=.UF^a>?5'9Kn[;433QFVV9M..2eN.@4ZWPGbdi<=?[:T>y?SD(R*-3It"Vj:)"dP
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-archive-position: 8689
X-ecartis-version: Ecartis v1.0.0
Sender: netdev-bounce@oss.sgi.com
Errors-to: netdev-bounce@oss.sgi.com
X-original-sender: davem@davemloft.net
Precedence: bulk
X-list: netdev
Content-Length: 540
Lines: 19

On Sat, 11 Sep 2004 10:53:53 +0300 (EEST)
Julian Anastasov <ja@ssi.bg> wrote:

> 	This is a resend/resync for v2.6.9-rc1-bk17: change the
> way the ip_nat_ftp helper manipulates the packets:
> 
> - no manips => no fixup
> 
> - check the direction, do manip once and at the same time when the
> headers are changed
> 
> 	This is needed mostly for IPVS setups and I hope we do not
> create troubles for other setups or FTP software.
> 
> Signed-off-by: Julian Anastasov <ja@ssi.bg>

Harald and/or Rusty, please ACK/NACK this for me.

Thanks.