Received: with ECARTIS (v1.0.0; list netdev); Mon, 13 Sep 2004 12:21:00 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [66.187.233.31]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id i8DJKtDj001223 for ; Mon, 13 Sep 2004 12:20:56 -0700 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.10) with ESMTP id i8DJKeBX024637; Mon, 13 Sep 2004 15:20:40 -0400 Received: from devserv.devel.redhat.com (devserv.devel.redhat.com [172.16.58.1]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i8DJKer01518; Mon, 13 Sep 2004 15:20:40 -0400 Received: from cheetah.davemloft.net (localhost.localdomain [127.0.0.1]) by devserv.devel.redhat.com (8.12.11/8.12.10) with SMTP id i8DJKY0c019482; Mon, 13 Sep 2004 15:20:35 -0400 Date: Mon, 13 Sep 2004 12:18:59 -0700 From: "David S. Miller" To: Andi Kleen Cc: netdev@oss.sgi.com, arjanv@redhat.com Subject: Re: [PATCH] Fix locking bug in lltx path Message-Id: <20040913121859.44fbf949.davem@redhat.com> In-Reply-To: References: X-Mailer: Sylpheed version 0.9.12 (GTK+ 1.2.10; sparc-unknown-linux-gnu) X-Face: "_;p5u5aPsO,_Vsx"^v-pEq09'CU4&Dc1$fQExov$62l60cgCc%FnIwD=.UF^a>?5'9Kn[;433QFVV9M..2eN.@4ZWPGbdi<=?[:T>y?SD(R*-3It"Vj:)"dP Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-archive-position: 8730 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: davem@redhat.com Precedence: bulk X-list: netdev Content-Length: 405 Lines: 15 On Mon, 13 Sep 2004 20:11:00 +0200 Andi Kleen wrote: > Thanks to Arjan's spinlock debug kernel for finding it. > > This fixes a silly missing spin lock in the relock path. For some > reason it seems to still work when you don't have spinlock debugging > enabled. > > Please apply. Good catch, but I'll need to fix this up to use the new macros defined in linux/netdevice.h Thanks again.