Received: with ECARTIS (v1.0.0; list netdev); Mon, 13 Sep 2004 13:04:48 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [66.187.233.31]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id i8DK4goH003033 for ; Mon, 13 Sep 2004 13:04:43 -0700 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.10) with ESMTP id i8DK4Rc3005009; Mon, 13 Sep 2004 16:04:27 -0400 Received: from devserv.devel.redhat.com (devserv.devel.redhat.com [172.16.58.1]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i8DK4Qr17105; Mon, 13 Sep 2004 16:04:26 -0400 Received: from cheetah.davemloft.net (localhost.localdomain [127.0.0.1]) by devserv.devel.redhat.com (8.12.11/8.12.10) with SMTP id i8DK4Jx4010832; Mon, 13 Sep 2004 16:04:20 -0400 Date: Mon, 13 Sep 2004 13:02:44 -0700 From: "David S. Miller" To: Andi Kleen Cc: ak@muc.de, netdev@oss.sgi.com, arjanv@redhat.com Subject: Re: [PATCH] Fix locking bug in lltx path Message-Id: <20040913130244.20a92a93.davem@redhat.com> In-Reply-To: <20040913192649.GA26975@wotan.suse.de> References: <20040913121859.44fbf949.davem@redhat.com> <20040913192649.GA26975@wotan.suse.de> X-Mailer: Sylpheed version 0.9.12 (GTK+ 1.2.10; sparc-unknown-linux-gnu) X-Face: "_;p5u5aPsO,_Vsx"^v-pEq09'CU4&Dc1$fQExov$62l60cgCc%FnIwD=.UF^a>?5'9Kn[;433QFVV9M..2eN.@4ZWPGbdi<=?[:T>y?SD(R*-3It"Vj:)"dP Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-archive-position: 8734 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: davem@redhat.com Precedence: bulk X-list: netdev Content-Length: 781 Lines: 26 On Mon, 13 Sep 2004 21:26:49 +0200 Andi Kleen wrote: > On Mon, Sep 13, 2004 at 12:18:59PM -0700, David S. Miller wrote: > > On Mon, 13 Sep 2004 20:11:00 +0200 > > Andi Kleen wrote: > > > > > Thanks to Arjan's spinlock debug kernel for finding it. > > > > > > This fixes a silly missing spin lock in the relock path. For some > > > reason it seems to still work when you don't have spinlock debugging > > > enabled. > > > > > > Please apply. > > > > Good catch, but I'll need to fix this up to use the new macros > > defined in linux/netdevice.h > > Ok, do you want me to send a new patch with that? I'll take care of it. > I don't think the new macros are in -bk* snapshots yet, > and getting it otherwise is difficult for me. It's in 2.6.9-rc2