Received: with ECARTIS (v1.0.0; list netdev); Mon, 13 Sep 2004 12:27:14 -0700 (PDT) Received: from Cantor.suse.de (cantor.suse.de [195.135.220.2]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id i8DJR79F001638 for ; Mon, 13 Sep 2004 12:27:08 -0700 Received: from hermes.suse.de (hermes-ext.suse.de [195.135.221.8]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (No client certificate requested) by Cantor.suse.de (Postfix) with ESMTP id 0A333BDF02F; Mon, 13 Sep 2004 21:26:52 +0200 (CEST) Date: Mon, 13 Sep 2004 21:26:49 +0200 From: Andi Kleen To: "David S. Miller" Cc: Andi Kleen , netdev@oss.sgi.com, arjanv@redhat.com Subject: Re: [PATCH] Fix locking bug in lltx path Message-ID: <20040913192649.GA26975@wotan.suse.de> References: <20040913121859.44fbf949.davem@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040913121859.44fbf949.davem@redhat.com> X-archive-position: 8731 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: ak@suse.de Precedence: bulk X-list: netdev Content-Length: 696 Lines: 23 On Mon, Sep 13, 2004 at 12:18:59PM -0700, David S. Miller wrote: > On Mon, 13 Sep 2004 20:11:00 +0200 > Andi Kleen wrote: > > > Thanks to Arjan's spinlock debug kernel for finding it. > > > > This fixes a silly missing spin lock in the relock path. For some > > reason it seems to still work when you don't have spinlock debugging > > enabled. > > > > Please apply. > > Good catch, but I'll need to fix this up to use the new macros > defined in linux/netdevice.h Ok, do you want me to send a new patch with that? I don't think the new macros are in -bk* snapshots yet, and getting it otherwise is difficult for me. It's probably fastest if you just apply it by hand. -Andi