Received: with ECARTIS (v1.0.0; list netdev); Thu, 10 Feb 2005 17:33:07 -0800 (PST) Received: from cheetah.davemloft.net (mail@adsl-63-197-226-105.dsl.snfc21.pacbell.net [63.197.226.105]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id j1B1WxJ2028264 for ; Thu, 10 Feb 2005 17:33:02 -0800 Received: from localhost ([127.0.0.1] helo=cheetah.davemloft.net ident=davem) by cheetah.davemloft.net with smtp (Exim 3.36 #1 (Debian)) id 1CzPf7-0004KA-00; Thu, 10 Feb 2005 17:32:01 -0800 Date: Thu, 10 Feb 2005 17:32:01 -0800 From: "David S. Miller" To: Pablo Neira Cc: netdev@oss.sgi.com Subject: Re: [PATCH 1/4] [NETLINK] fix broken indentation in netlink.h Message-Id: <20050210173201.21da89e5.davem@davemloft.net> In-Reply-To: <420BF8C3.3050305@eurodev.net> References: <420BF8C3.3050305@eurodev.net> X-Mailer: Sylpheed version 1.0.0 (GTK+ 1.2.10; sparc-unknown-linux-gnu) X-Face: "_;p5u5aPsO,_Vsx"^v-pEq09'CU4&Dc1$fQExov$62l60cgCc%FnIwD=.UF^a>?5'9Kn[;433QFVV9M..2eN.@4ZWPGbdi<=?[:T>y?SD(R*-3It"Vj:)"dP Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV version 0.81, clamav-milter version 0.81b on oss.sgi.com X-Virus-Status: Clean X-archive-position: 1501 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: davem@davemloft.net Precedence: bulk X-list: netdev Content-Length: 654 Lines: 26 On Fri, 11 Feb 2005 01:13:55 +0100 Pablo Neira wrote: > the subject says all Don't split up lines like from: extern int func(...); into: extern int func(...); That's just gross and means that when I run grep on the tree I won't see the function's return type for hits, I'll only see the args. Just keep the long declarations. Why don't you bypass all the cleanup diffs and just do the functionality change instead? When you mix whitespace and coding style cleanups with real changes, it puts your real changes at risk if we think your cleanups are ugly or bogus since you've created a patch dependency. One thing at a time.