Received: with ECARTIS (v1.0.0; list netdev); Sat, 26 Mar 2005 05:36:51 -0800 (PST) Received: from mail.holtmann.net (coyote.holtmann.net [217.160.111.169]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id j2QDakem024170 for ; Sat, 26 Mar 2005 05:36:47 -0800 Received: from pegasus (pD9525B19.dip.t-dialin.net [217.82.91.25]) by mail.holtmann.net (8.12.3/8.12.3/Debian-7.1) with ESMTP id j2QDaLbo016723 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Sat, 26 Mar 2005 14:36:21 +0100 Subject: Re: [NET] make all protos partially use sk_prot From: Marcel Holtmann To: Arnaldo Carvalho de Melo Cc: Arnaldo Carvalho de Melo , "David S. Miller" , Network Development Mailing List In-Reply-To: <39e6f6c7050326051571ef8272@mail.gmail.com> References: <20050326003937.GA13951@conectiva.com.br> <1111842541.9195.183.camel@pegasus> <39e6f6c705032605136bd797b2@mail.gmail.com> <39e6f6c7050326051571ef8272@mail.gmail.com> Content-Type: text/plain Date: Sat, 26 Mar 2005 14:36:03 +0100 Message-Id: <1111844163.9195.191.camel@pegasus> Mime-Version: 1.0 X-Mailer: Evolution 2.0.4 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.83/789/Fri Mar 25 21:33:13 2005 on oss.sgi.com X-Virus-Scanned: ClamAV 0.83/788/Sat Mar 26 00:07:36 2005 on coyote.holtmann.net X-Virus-Status: Clean X-archive-position: 739 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: marcel@holtmann.org Precedence: bulk X-list: netdev Content-Length: 522 Lines: 20 Hi Arnaldo, > Ah, apart from these style changes, do you think the real changes in this patch > are worth? actually I am the wrong person to judge on this. However if socket users don't have to care about owner and slab anymore (or at least less), I think it is a good thing to do. Btw all the ".slab = NULL," stuff in the proto declarations is not needed and we normally omit values that are 0 or NULL. And some of the proto__seq_* functions are not static. What is the reason to have them public? Regards Marcel