Received: with ECARTIS (v1.0.0; list netdev); Tue, 08 Mar 2005 04:49:18 -0800 (PST)
Received: from yue.st-paulia.net (yue.linux-ipv6.org [203.178.140.15])
	by oss.sgi.com (8.13.0/8.13.0) with ESMTP id j28CnAHM011086
	for <netdev@oss.sgi.com>; Tue, 8 Mar 2005 04:49:10 -0800
Received: from localhost (localhost [127.0.0.1])
	by yue.st-paulia.net (Postfix) with ESMTP
	id EB93433CC2; Tue,  8 Mar 2005 21:50:46 +0900 (JST)
Date: Tue, 08 Mar 2005 06:50:46 -0600 (CST)
Message-Id: <20050308.065046.66114517.yoshfuji@linux-ipv6.org>
To: herbert@gondor.apana.org.au
Cc: davem@davemloft.net, kuznet@ms2.inr.ac.ru, jmorris@redhat.com,
        netdev@oss.sgi.com, yoshfuji@linux-ipv6.org
Subject: Re: [11/*] [NET] Move dst_release out of dst->ops->check
From: YOSHIFUJI Hideaki / =?iso-2022-jp?B?GyRCNUhGIzFRTEAbKEI=?= <yoshfuji@linux-ipv6.org>
In-Reply-To: <20050308102741.GA23468@gondor.apana.org.au>
References: <20050306213214.7d8a143d.davem@davemloft.net>
	<20050307103536.GB7137@gondor.apana.org.au>
	<20050308102741.GA23468@gondor.apana.org.au>
Organization: USAGI Project
X-URL: http://www.yoshifuji.org/%7Ehideaki/
X-Fingerprint: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA
X-PGP-Key-URL: http://www.yoshifuji.org/%7Ehideaki/hideaki@yoshifuji.org.asc
X-Face: "5$Al-.M>NJ%a'@hhZdQm:."qn~PA^gq4o*>iCFToq*bAi#4FRtx}enhuQKz7fNqQz\BYU]
 $~O_5m-9'}MIs`XGwIEscw;e5b>n"B_?j/AkL~i/MEa<!5P`&C$@oP>ZBLP
X-Mailer: Mew version 2.2 on Emacs 20.7 / Mule 4.1 (AOI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: ClamAV 0.83/755/Mon Mar  7 17:00:18 2005 on oss.sgi.com
X-Virus-Status: Clean
X-archive-position: 2641
X-ecartis-version: Ecartis v1.0.0
Sender: netdev-bounce@oss.sgi.com
Errors-to: netdev-bounce@oss.sgi.com
X-original-sender: yoshfuji@linux-ipv6.org
Precedence: bulk
X-list: netdev
Content-Length: 629
Lines: 16

In article <20050308102741.GA23468@gondor.apana.org.au> (at Tue, 8 Mar 2005 21:27:41 +1100), Herbert Xu <herbert@gondor.apana.org.au> says:

> On Mon, Mar 07, 2005 at 09:35:36PM +1100, herbert wrote:
> > 
> > Here's the patch to fix those two problems.  Yes I know
> > my dst_check implementation is lame.  I'll come back and
> > fix up all the dst_check functions by moving their dst_release
> > calls out.  It proves that you were right in that IPv6 dst
> > leak thread :)
> 
> As promised here is the patch that moves dst_release out of
> dst->ops->check.  It bloats sk_dst_check/__sk_dst_check slightly

I agree.

--yoshfuji