Received: with ECARTIS (v1.0.0; list netdev); Tue, 08 Mar 2005 09:45:39 -0800 (PST) Received: from www.lanforge.com (ns1.lanforge.com [66.165.47.210]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id j28HjWVc016425 for ; Tue, 8 Mar 2005 09:45:32 -0800 Received: from [4.33.45.22] (evrtwa1-ar2-4-33-045-022.evrtwa1.dsl-verizon.net [4.33.45.22]) (authenticated bits=0) by www.lanforge.com (8.12.8/8.12.8) with ESMTP id j28I8RLH015966; Tue, 8 Mar 2005 10:08:28 -0800 Message-ID: <422DE4B0.6040201@candelatech.com> Date: Tue, 08 Mar 2005 09:45:20 -0800 From: Ben Greear Organization: Candela Technologies User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.3) Gecko/20041020 X-Accept-Language: en-us, en MIME-Version: 1.0 To: hadi@cyberus.ca CC: Patrick McHardy , leo@yuriev.ru, Lennert Buytenhek , shemminger@osdl.org, netdev@oss.sgi.com Subject: Re: [leo@yuriev.ru: [PATCH] ethernet-bridge: update skb->priority in case forwarded frame has VLAN-header] References: <20050305141225.GA5180@xi.wantstofly.org> <4229D98F.9010008@trash.net> <422A0C21.3050709@candelatech.com> <1110199696.1094.1299.camel@jzny.localdomain> <1110238537.1043.62.camel@jzny.localdomain> <422CE983.7060305@trash.net> <1110241190.1043.100.camel@jzny.localdomain> <422D1E26.1010902@trash.net> <1110287626.1043.146.camel@jzny.localdomain> In-Reply-To: <1110287626.1043.146.camel@jzny.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.83/755/Mon Mar 7 17:00:18 2005 on oss.sgi.com X-Virus-Status: Clean X-archive-position: 2665 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: greearb@candelatech.com Precedence: bulk X-list: netdev Content-Length: 976 Lines: 30 jamal wrote: > On Mon, 2005-03-07 at 22:38, Patrick McHardy wrote: > >>jamal wrote: >> >>>Indeed that looks bad. But wouldnt have helped if we started at 0 >>>either. You need monotonically increasing values to make proper >>>sense. So i suppose to do proper qos with L2, one must install the prio >>>qdisc and rewrite the priomap. >> >>One reason more to move it to an optional ebtables target. Or leave it >>all to prio + u32. But I guess a CLASSIFY target similar to iptables >>could also be useful otherwise. > > > I think you still want (perhaps the vlan) driver to come up with some > sane defaults. From what i read from bgrear he has arbitrary values. By default, everything is mapped to priority of zero, but the user can specify a mapping to any integer they desire. If you have some suggestions for some defaults better than zero, I'm willing to consider it. Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com