Received: with ECARTIS (v1.0.0; list netdev); Sat, 30 Apr 2005 11:13:19 -0700 (PDT) Received: from kaber.coreworks.de ([62.206.217.67]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id j3UIDH7J014721 for ; Sat, 30 Apr 2005 11:13:17 -0700 Received: from localhost ([127.0.0.1]) by kaber.coreworks.de with esmtp (Exim 4.50) id 1DRwSl-0006T5-Du; Sat, 30 Apr 2005 20:13:11 +0200 Message-ID: <4273CAB7.6080403@trash.net> Date: Sat, 30 Apr 2005 20:13:11 +0200 From: Patrick McHardy User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.6) Gecko/20050324 Debian/1.7.6-1 X-Accept-Language: en MIME-Version: 1.0 To: hadi@cyberus.ca CC: netdev , "David S. Miller" Subject: Re: patch: Action repeat References: <1114879817.8929.117.camel@localhost.localdomain> <4273BB30.1050402@trash.net> <4273BBAA.6060405@trash.net> <1114882045.8929.123.camel@localhost.localdomain> In-Reply-To: <1114882045.8929.123.camel@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.83/861/Sat Apr 30 02:28:52 2005 on oss.sgi.com X-Virus-Status: Clean X-archive-position: 470 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: kaber@trash.net Precedence: bulk X-list: netdev Content-Length: 585 Lines: 16 jamal wrote: > Actions can set it. > Theres one in particular that i havent submitted yet that sets it > amongst other items (depending on policy). We discussed this a while > back when talking about ematches etc. Since it only has such a short lifetime (action function sets it, tcf_action_exec() clears it after changing classification result), it would be less wasteful to just pass the classification result to the actions. This would also avoid that skbs with tc_classid already set can reach tcf_action_exec() (for example through mirred). What do you think? Regards Patrick