Received: with ECARTIS (v1.0.0; list netdev); Tue, 24 May 2005 11:27:10 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [66.187.233.31]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id j4OIR0Xq017497 for ; Tue, 24 May 2005 11:27:00 -0700 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j4OIQ9bu003688; Tue, 24 May 2005 14:26:09 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j4OIQ9O02841; Tue, 24 May 2005 14:26:09 -0400 Received: from wbar1.sjo1-4-4-004-002.sjo1.dsl-verizon.net (vpn50-38.rdu.redhat.com [172.16.50.38]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id j4OIQ8sR003874; Tue, 24 May 2005 14:26:09 -0400 Subject: Re: [PATCH] bonding using arp_ip_target may stay down with active path From: Eric Paris To: Jay Vosburgh Cc: "David S. Miller" , netdev@oss.sgi.com, jgarzik@pobox.com, bonding-devel@lists.sourceforge.net In-Reply-To: <200505232121.j4NLLaYa000837@death.nxdomain.ibm.com> References: <200505232121.j4NLLaYa000837@death.nxdomain.ibm.com> Content-Type: text/plain Date: Tue, 24 May 2005 14:26:40 -0400 Message-Id: <1116959200.8954.5.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.0.4 (2.0.4-4) Content-Transfer-Encoding: 7bit X-archive-position: 1604 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: eparis@parisplace.org Precedence: bulk X-list: netdev Content-Length: 1274 Lines: 33 >On Mon, 2005-05-23 at 14:21 -0700, Jay Vosburgh wrote: David S. Miller wrote: >Patch doesn't apply, tabs turned into spaces by your >email client. > > As penance for test applying trivial patches by hand, here's a >proper version. > > -J > >--- > -Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com I guess I should be in the signed off list as the original author. sorry I'm an idiot and copied and pasted my original message (to the bonding-devel list) which screwed up the spacing. Signed-off-by: Eric Paris Signed-off-by: Jay Vosburgh diff -urN linux-2.6.11/drivers/net/bonding/bond_main.c linux-2.6.11-fix/drivers/net/bonding/bond_main.c --- linux-2.6.11/drivers/net/bonding/bond_main.c 2005-05-23 14:07:37.000000000 -0700 +++ linux-2.6.11-fix/drivers/net/bonding/bond_main.c 2005-05-23 14:08:13.000000000 -0700 @@ -3046,7 +3046,7 @@ bond_set_slave_inactive_flags(bond->current_arp_slave); /* search for next candidate */ - bond_for_each_slave_from(bond, slave, i, bond->current_arp_slave) { + bond_for_each_slave_from(bond, slave, i, bond->current_arp_slave->next) { if (IS_UP(slave->dev)) { slave->link = BOND_LINK_BACK; bond_set_slave_active_flags(slave);