Received: with ECARTIS (v1.0.0; list netdev); Thu, 16 Jun 2005 16:53:26 -0700 (PDT) Received: from wproxy.gmail.com (wproxy.gmail.com [64.233.184.192]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id j5GNrLH9018720 for ; Thu, 16 Jun 2005 16:53:22 -0700 Received: by wproxy.gmail.com with SMTP id 68so776192wri for ; Thu, 16 Jun 2005 16:52:05 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=MWGLVFYPYzXkCMx5FuYadX+ktfo82/ehUHL2Z2V8cwH0GoTenu90xuDi6/fwgaYG3rvNAHcymZ1nS1bLk1CRCaOgMyw5nsTfmbOtTSgX7kbKpQo0UlyzRRD6X0LjpqcPSYDfgUEEBkmaQgUqdQhbhhq1e0j+rpagQ1Gpo0XCHP8= Received: by 10.54.26.72 with SMTP id 72mr929648wrz; Thu, 16 Jun 2005 16:52:04 -0700 (PDT) Received: by 10.54.13.22 with HTTP; Thu, 16 Jun 2005 16:52:04 -0700 (PDT) Message-ID: <43e72e8905061616527858ebd6@mail.gmail.com> Date: Thu, 16 Jun 2005 19:52:04 -0400 From: "Luis R. Rodriguez" Reply-To: "Luis R. Rodriguez" To: Olaf Hering Subject: Re: [PATCH] uninitialized variable in prism54 isl38xx_trigger_device Cc: Jeff Garzik , netdev@oss.sgi.com, prism54-private@prism54.org In-Reply-To: <20050525231651.GA21816@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Disposition: inline References: <20050525231651.GA21816@suse.de> Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by oss.sgi.com id j5GNrLH9018720 X-archive-position: 2443 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: mcgrof@gmail.com Precedence: bulk X-list: netdev Content-Length: 2238 Lines: 52 Sure, why not. This has been applied to prism54 svn tree. On 5/25/05, Olaf Hering wrote: > > drivers/net/wireless/prism54/isl_38xx.c:131: warning: 'current_time.tv_sec' is used uninitialized in this function > drivers/net/wireless/prism54/isl_38xx.c:131: warning: 'current_time.tv_usec' is used uninitialized in this function > > Signed-off-by: Olaf Hering > Index: linux-2.6.12-rc5-olh/drivers/net/wireless/prism54/isl_38xx.c > =================================================================== > --- linux-2.6.12-rc5-olh.orig/drivers/net/wireless/prism54/isl_38xx.c > +++ linux-2.6.12-rc5-olh/drivers/net/wireless/prism54/isl_38xx.c > @@ -112,10 +112,10 @@ isl38xx_handle_wakeup(isl38xx_control_bl > void > isl38xx_trigger_device(int asleep, void __iomem *device_base) > { > - struct timeval current_time; > u32 reg, counter = 0; > > #if VERBOSE > SHOW_ERROR_MESSAGES > + struct timeval current_time; > DEBUG(SHOW_FUNCTION_CALLS, "isl38xx trigger device\n"); > #endif > > @@ -126,11 +126,11 @@ isl38xx_trigger_device(int asleep, void > do_gettimeofday(¤t_time); > DEBUG(SHOW_TRACING, "%08li.%08li Device wakeup triggered\n", > current_time.tv_sec, (long)current_time.tv_usec); > -#endif > > DEBUG(SHOW_TRACING, "%08li.%08li Device register read %08x\n", > current_time.tv_sec, (long)current_time.tv_usec, > readl(device_base + ISL38XX_CTRL_STAT_REG)); > +#endif > udelay(ISL38XX_WRITEIO_DELAY); > > reg = readl(device_base + ISL38XX_INT_IDENT_REG); > @@ -148,10 +148,12 @@ isl38xx_trigger_device(int asleep, void > counter++; > } > > +#if VERBOSE > SHOW_ERROR_MESSAGES > DEBUG(SHOW_TRACING, > "%08li.%08li Device register read %08x\n", > current_time.tv_sec, (long)current_time.tv_usec, > readl(device_base + ISL38XX_CTRL_STAT_REG)); > +#endif > udelay(ISL38XX_WRITEIO_DELAY); > > #if VERBOSE > SHOW_ERROR_MESSAGES >