Received:  by oss.sgi.com id <S305166AbQDMSRG>;
	Thu, 13 Apr 2000 11:17:06 -0700
Received: from deliverator.sgi.com ([204.94.214.10]:9246 "EHLO
        deliverator.sgi.com") by oss.sgi.com with ESMTP id <S305159AbQDMSQr>;
	Thu, 13 Apr 2000 11:16:47 -0700
Received: from ledzep.cray.com (ledzep.cray.com [137.38.226.97]) by deliverator.sgi.com (980309.SGI.8.8.8-aspam-6.2/980310.SGI-aspam) via ESMTP id LAA25512
	for <linux-xfs@oss.sgi.com>; Thu, 13 Apr 2000 11:12:04 -0700 (PDT)
	mail_from (lord@sgi.com)
Received: from ironwood-e185.americas.sgi.com (ironwood.cray.com [128.162.185.212]) by ledzep.cray.com (SGI-SGI-8.9.3/craymail-smart-nospam1.0) with ESMTP id NAA84154; Thu, 13 Apr 2000 13:15:30 -0500 (CDT)
Received: from jen.americas.sgi.com (jen.americas.sgi.com [128.162.184.86]) by ironwood-e185.americas.sgi.com (8.8.4/SGI-ironwood-e1.4) with ESMTP id NAA29660; Thu, 13 Apr 2000 13:15:22 -0500 (CDT)
Received: from jen.americas.sgi.com by jen.americas.sgi.com (8.9.3/SGI-client.1.6) via ESMTP id NAA07305; Thu, 13 Apr 2000 13:15:17 -0500
Message-Id: <200004131815.NAA07305@jen.americas.sgi.com>
X-Mailer: exmh version 2.1.1 10/15/1999
To:     cattelan@thebarn.com, linux-xfs@oss.sgi.com
Subject: Re: XFS as Root filesystem 
In-Reply-To: Message from Phil Schwan <phil@linuxcare.com> 
   of "Thu, 13 Apr 2000 14:54:36 EDT." <20000413145436.D1665@linuxcare.com> 
Date:   Thu, 13 Apr 2000 13:15:16 -0500
From:   Steve Lord <lord@sgi.com>
Sender: owner-linux-xfs@oss.sgi.com
Precedence: bulk
Return-Path: <owner-linux-xfs@oss.sgi.com>
X-Orcpt: rfc822;linux-xfs-outgoing

> On Apr 13, cattelan@thebarn.com wrote:
> > First it would be best not to include linux/fs.h in any file
> > not in the fs/xfs/linux directory. It will cause headaches.
> > 
> > If fact that linux/xfs_sema.h shouldn't be there either.
> > 
> > If the file is general enough say types.h it can go
> > in xfs_os_defs.h; I doesn't really hurt if some
> > *.c files include some header files they don't need.
> > As long as it doesn't create conflicts.
> > 


Have you run cscope recently:

Files #including this file: xfs_sema.h

  File                      Line
1 fs/xfs/xfsquotasstubs.c    84 #include <linux/xfs_sema.h>
2 fs/xfs/xfs_bmap.c          40 #include <linux/xfs_sema.h>
3 fs/xfs/xfs_buf.h           48 #include <linux/xfs_sema.h>
4 fs/xfs/xfs_buf.h          289 #include <linux/xfs_sema.h>
5 fs/xfs/xfs_log_print.c     51 #include <linux/xfs_sema.h>
7 fs/xfs/xfs_grio.c          41 #include <linux/xfs_sema.h>
8 fs/xfs/xfs_mount.c         51 #include <linux/xfs_sema.h>
9 xfs/linux/xfs_vnode.c      47 #include <linux/xfs_sema.h>
1 pseudo-inc/sys/sema_priva  50 #include <linux/xfs_sema.h>
2 pseudo-inc/ksys/behavior. 150 #include <linux/xfs_sema.h>
3 fs/xfs/xfs_dfrag.c         39 #include <linux/xfs_sema.h>
4 xfs/linux/xfs_random.c    155 #include <linux/xfs_sema.h>
5 fs/xfs/xfs_iocore.c        62 #include <linux/xfs_sema.h>
6 fs/xfs/xfs_vfsops.c        70 #include <linux/xfs_sema.h>
7 pseudo-inc/sys/vfs.h       75 #include <linux/xfs_sema.h>
8 pseudo-inc/ksys/kqueue.h   57 #include <linux/xfs_sema.h>
9 xfs/linux/xfs_fs_bio.c     47 #include <linux/xfs_sema.h>
1 fs/xfs/xfs_itable.c        41 #include <linux/xfs_sema.h>
2 fs/xfs/xfs_log_recover.c   46 #include <linux/xfs_sema.h>
3 fs/xfs/xfs_vnodeops.c      73 #include <linux/xfs_sema.h>
4 pseudo-inc/sys/vnode.h     68 #include <linux/xfs_sema.h>
5 fs/xfs/xfs_rw.c            54 #include <linux/xfs_sema.h>
6 pseudo-inc/sys/buf.h       63 #include <linux/xfs_sema.h>
7 fs/xfs/xfs_log.c           64 #include <linux/xfs_sema.h>
8 xfs/linux/xfs_uuid.c       73 #include <linux/xfs_sema.h>
9 fs/xfs/xfs_fsops.c         41 #include <linux/xfs_sema.h>
1 fs/xfs/xfs_macros.c        43 #include <linux/xfs_sema.h>

And:

Files #including this file: linux/fs.h
4 fs/xfs/xfs_vfsops.c        41 #include <linux/fs.h>

And pseudo-inc/sys/capability.h (included by a number of files) includes

#include <linux/capability.h>
#include <linux/sched.h>

and linux/capability.h includes fs.h


Changing one occurrence is not going to make a difference at the moment.

Steve