From:   Thomas Graichen <news-innominate.list.sgi.xfs@innominate.de>
Reply-To: Thomas Graichen <graichen@innominate.de>
Subject: Re: nfs fix for test5
Date:   27 Sep 2000 14:19:55 GMT
Organization: innominate AG, Berlin, Germany
Lines:  60
Distribution: local
Message-ID: <news2mail-8qsvmb$fik$2@mate.bln.innominate.de>
References: <8qsvk8$fik$1@mate.bln.innominate.de>
Reply-To: thomas.graichen@innominate.de
User-Agent: tin/1.4.2-20000205 ("Possession") (UNIX) (Linux/2.4.0-test5 (i586))
To:     linux-xfs@oss.sgi.com
Sender: owner-linux-xfs@oss.sgi.com
Precedence: bulk

one simple side note tomake it more clear: this thing has nothing
to do with XFS itself - only with the fact that the xfs tree
currently uses the -test5 kernel which has this problem ...

t

Thomas Graichen <graichen@innominate.de> wrote:
> the following patch fixes a small nfs problem in -test5 (on which the
> SGI XFS tree is currently based and which is fixed in later test
> versions) ... it manifests itself in the fact that you have problems
> writing big files with your machine being nfs client ... maybe it's
> worth to add it to the tree as long as it stays at -test5 ... for me
> here (linux xfs kernel nfs client to an linux normal nfs server)
> this is the only way to really use this kernel in this envirnonment
> and it might be the case for other beta tester too (btw. the patch
> comes from the linux nfs mailinglist)

> hope that helps

> t

> p.s.: ... and now the patch

> Index: write.c
> ===================================================================
> RCS file: /cvs/linux-2.4-xfs/linux/fs/nfs/write.c,v
> retrieving revision 1.18
> diff -u -r1.18 write.c
> --- write.c	2000/06/02 00:22:59	1.18
> +++ write.c	2000/09/27 14:06:28
> @@ -1294,7 +1294,7 @@
>  	struct nfs_page		*req;
>  	struct dentry		*dentry;
>  	struct inode		*inode;
> -	loff_t			start, end, len;
> +	u64			start, end, len;
>  
>  	/* Set up the RPC argument and reply structs
>  	 * NB: take care not to mess about with data->commit et al. */
> @@ -1308,7 +1308,7 @@
>  	inode = dentry->d_inode;
>  	while (!list_empty(head)) {
>  		struct nfs_page	*req;
> -		loff_t	rqstart, rqend;
> +		u64	rqstart, rqend;
>  		req = nfs_list_entry(head->next);
>  		nfs_list_remove_request(req);
>  		nfs_list_add_request(req, &data->pages);

> -- 
> thomas.graichen@innominate.de
> technical director                                       innominate AG
> clustering & security                                networking people
> tel: +49.30.308806-13  fax: -77                   http://innominate.de

-- 
thomas.graichen@innominate.de
technical director                                       innominate AG
clustering & security                                networking people
tel: +49.30.308806-13  fax: -77                   http://innominate.de