Received: by oss.sgi.com id ; Mon, 11 Dec 2000 17:13:39 -0800 Received: from deliverator.sgi.com ([204.94.214.10]:25913 "EHLO deliverator.sgi.com") by oss.sgi.com with ESMTP id ; Mon, 11 Dec 2000 17:13:12 -0800 Received: from cthulhu.engr.sgi.com (cthulhu.engr.sgi.com [192.26.80.2]) by deliverator.sgi.com (980309.SGI.8.8.8-aspam-6.2/980310.SGI-aspam) via ESMTP id RAA23910 for ; Mon, 11 Dec 2000 17:13:12 -0800 (PST) mail_from (hawkes@engr.sgi.com) Received: from pchawkes (sshgate.corp.sgi.com [169.238.216.146]) by cthulhu.engr.sgi.com (SGI-8.9.3/8.9.3) with SMTP id RAA13589; Mon, 11 Dec 2000 17:11:48 -0800 (PST) Message-ID: <012001c063d8$3c4ae180$6401a8c0@marin1.sfba.home.com> From: "John Hawkes" To: "Keith Owens" , "Rajagopal Ananthanarayanan" Cc: References: <1700.976576626@kao2.melbourne.sgi.com> Subject: Re: CONFIG_FRAME_POINTER and arch/i386/kernel/semaphore.c Date: Mon, 11 Dec 2000 17:09:53 -0800 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4133.2400 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400 Sender: owner-linux-xfs@oss.sgi.com Precedence: bulk Return-Path: X-Orcpt: rfc822;linux-xfs-outgoing From: "Keith Owens" ... > For consistency I will add frame pointers to the routines > that do not have it but recommend that frame pointers not be used. As it turns out, kernprof's mcount functionality claims to need frame pointers (to the point where the high-level kernel Makefile turns on CONFIG_FRAME_POINTER if CONFIG_MCOUNT is set), yet the current version 0.9 of the kernprof patch doesn't mimic what the kdb patch does in semaphore.c and insert the frame pointer instructions into the entry and exit of those selected asm routines. Unless someone tells me I'm wrong, I'll add those CONFIG_FRAME_POINTER instructions into the kernprof patch. John Hawkes