Received: with ECARTIS (v1.0.0; list linux-xfs); Thu, 10 Jun 2004 04:55:25 -0700 (PDT) Received: from TYO201.gate.nec.co.jp (TYO201.gate.nec.co.jp [202.32.8.214]) by oss.sgi.com (8.12.10/8.12.9) with SMTP id i5ABtLgi002651 for ; Thu, 10 Jun 2004 04:55:22 -0700 Received: from mailgate3.nec.co.jp (mailgate53.nec.co.jp [10.7.69.162] (may be forged)) by TYO201.gate.nec.co.jp (8.11.7/3.7W01080315) with ESMTP id i5ABtFp04173 for ; Thu, 10 Jun 2004 20:55:15 +0900 (JST) Received: (from root@localhost) by mailgate3.nec.co.jp (8.11.7/3.7W-MAILGATE-NEC) id i5ABtF602601 for linux-xfs@oss.sgi.com; Thu, 10 Jun 2004 20:55:15 +0900 (JST) Received: from secsv3.tnes.nec.co.jp (tnesvc2.tnes.nec.co.jp [10.1.101.15]) by mailsv5.nec.co.jp (8.11.7/3.7W-MAILSV4-NEC) with ESMTP id i5ABtEa21192 for ; Thu, 10 Jun 2004 20:55:14 +0900 (JST) Received: from tnesvc2.tnes.nec.co.jp ([10.1.101.15]) by secsv3.tnes.nec.co.jp (ExpressMail 5.10) with SMTP id 20040610.205755.46802648 for ; Thu, 10 Jun 2004 20:57:55 +0900 Received: FROM tnesgate.tnes.nec.co.jp BY tnesvc2.tnes.nec.co.jp ; Thu Jun 10 20:57:55 2004 +0900 Received: from rifu.bsd.tnes.nec.co.jp (rifu.bsd.tnes.nec.co.jp [10.1.104.1]) by tnesgate.tnes.nec.co.jp (8.11.6/3.7W00091816) with ESMTP id i5ABtDX21634; Thu, 10 Jun 2004 20:55:13 +0900 (JST) Received: from tnesb9665.tnes.nec.co.jp (bsd240.bsd.tnes.nec.co.jp [10.1.104.104]) by rifu.bsd.tnes.nec.co.jp (8.11.6/3.7W/BSD-TNES-MX01) with SMTP id i5ABtDX32370; Thu, 10 Jun 2004 20:55:13 +0900 Message-Id: <200406101155.AA00203@tnesb9665.tnes.nec.co.jp> From: Masanori TSUDA Date: Thu, 10 Jun 2004 20:55:13 +0900 To: Nathan Scott Cc: linux-xfs@oss.sgi.com, Kazuyuki Goto Subject: Re: data corruption on nfs+xfs In-Reply-To: <20040610084803.GA620@frodo> References: <20040610084803.GA620@frodo> MIME-Version: 1.0 X-Mailer: AL-Mail32 Version 1.13 Content-Type: text/plain; charset=us-ascii X-archive-position: 3367 X-ecartis-version: Ecartis v1.0.0 Sender: linux-xfs-bounce@oss.sgi.com Errors-to: linux-xfs-bounce@oss.sgi.com X-original-sender: tsuda@tnes.nec.co.jp Precedence: bulk X-list: linux-xfs Content-Length: 1138 Lines: 40 Hi Nathan, Thank you for commenting. I am glad to contribute to development of XFS. Regards, Tsuda In message "Re: data corruption on nfs+xfs" (04/06/10 17:48:03), nathans@sgi.com wrote... >On Thu, Jun 10, 2004 at 10:30:31AM +0900, Masanori TSUDA wrote: >> Hi, > >Hi there, > >> I have reproduced similar problem on xfs1.3.1 (based on 2.4.21), >> my environment is as follows. >> >> I have investigated the issue using the kernel embeded local trace. >> I think that the issue was caused by the delayed allocation mechanism. >> I explain the example of curruption scenario which I guess. > >Thank you, and an excellent explanation too. I think you may >well have figured it out. > >> I think that one of solution for the issue is to flush only buffers in >> end of the file before allocating disk space for delayed allocation blocks, >> don't flush buffers over that. > >I'm sure Russell will have more to add tomorrow when he's >awake. I've ported your patch forward to current CVS (for >2.4 and 2.6 kernels), for my own testing purposes and have >included it below for anyone else who is interested. > >thanks! > >-- >Nathan