Received: with ECARTIS (v1.0.0; list linux-xfs); Thu, 24 Jun 2004 06:57:22 -0700 (PDT) Received: from iceberg.elsat.net.pl (iceberg.elsat.net.pl [217.173.160.37]) by oss.sgi.com (8.12.10/8.12.9) with SMTP id i5ODvIgi021904 for ; Thu, 24 Jun 2004 06:57:19 -0700 Received: from iceberg.elsat.net.pl (localhost.localdomain [127.0.0.1]) by iceberg.elsat.net.pl (8.12.11/8.12.11) with ESMTP id i5ODvMB3008733; Thu, 24 Jun 2004 15:57:22 +0200 Received: (from kszysiu@localhost) by iceberg.elsat.net.pl (8.12.11/8.12.11/Submit) id i5ODvM0i008730; Thu, 24 Jun 2004 15:57:22 +0200 Date: Thu, 24 Jun 2004 15:57:22 +0200 From: Krzysztof Rusocki To: Christoph Hellwig Cc: Nathan Scott , linux-xfs@oss.sgi.com Subject: Re: xfs oops (CVS-2004-05-15_05:00_UTC) Message-ID: <20040624135722.GG1323@iceberg.elsat.net.pl> References: <20040621021505.GA1173@frodo> <20040621025905.GA1323@iceberg.elsat.net.pl> <20040621072906.GD1656@frodo> <20040622082906.GA2093@frodo> <20040623084922.GD1323@iceberg.elsat.net.pl> <20040623203639.A1670881@wobbly.melbourne.sgi.com> <20040623131611.GE1323@iceberg.elsat.net.pl> <20040624024320.GB5866@frodo> <20040624114608.GF1323@iceberg.elsat.net.pl> <20040624121441.GA9419@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040624121441.GA9419@infradead.org> User-Agent: Mutt/1.4.1i X-archive-position: 3509 X-ecartis-version: Ecartis v1.0.0 Sender: linux-xfs-bounce@oss.sgi.com Errors-to: linux-xfs-bounce@oss.sgi.com X-original-sender: kszysiu@iceberg.elsat.net.pl Precedence: bulk X-list: linux-xfs Content-Length: 888 Lines: 27 On Thu, Jun 24, 2004 at 01:14:41PM +0100, Christoph Hellwig wrote: > > - current CVS without 1.1371.750.18 _and_ undelay changes - no problems > > (tested 10 hours) Ugh, this ^^^ seems to be no longer accurate. I'm guessing that these changes are not neccessarily to blame then (wild guess). > > - current CVS without 1.1371.750.18, 1.1587.5.6 1.1722.10.100 and undelay > > changes - no problems (tested 14 hours) (*) I'll test (*) again and vanilla 2.6.4 (as Nathan suggested)... > > + ASSERT(list_empty(&pb->pb_list)); > ASSERT(list_empty(&bp->pb_hash_list)); > + ASSERT(!(bp->pb_flags & PBF_DELWRI)); For the record: I changed these assertions to BUG_ON(! )s (as in Nathan's patch) since I do not have CONFIG_XFS_DEBUG (afaics these assertions are not enabled until CONFIG_XFS_DEBUG is set). But... no, these BUG_ONs were not triggered, and oops did happen. Krzysztof