Received: with ECARTIS (v1.0.0; list linux-xfs); Thu, 08 Sep 2005 08:28:00 -0700 (PDT) Received: from rwcrmhc11.comcast.net (rwcrmhc11.comcast.net [216.148.227.117]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id j88FRsiL002369 for ; Thu, 8 Sep 2005 08:27:54 -0700 Received: from c-66-30-115-133.hsd1.ma.comcast.net ([66.30.115.133]) by comcast.net (rwcrmhc11) with ESMTP id <2005090815251801300b3rsbe>; Thu, 8 Sep 2005 15:25:19 +0000 Received: from c-66-30-115-133.hsd1.ma.comcast.net (localhost.127.in-addr.arpa [127.0.0.1]) by c-66-30-115-133.hsd1.ma.comcast.net (8.13.4/8.13.1) with ESMTP id j88FPEsg048422; Thu, 8 Sep 2005 11:25:14 -0400 (EDT) (envelope-from rodrigc@c-66-30-115-133.hsd1.ma.comcast.net) Received: (from rodrigc@localhost) by c-66-30-115-133.hsd1.ma.comcast.net (8.13.4/8.13.1/Submit) id j88FPD6a048421; Thu, 8 Sep 2005 11:25:13 -0400 (EDT) (envelope-from rodrigc) Date: Thu, 8 Sep 2005 11:25:13 -0400 From: Craig Rodrigues To: Christoph Hellwig Cc: linux-xfs@oss.sgi.com Subject: Re: Warnings when compiling xfs_macros.c Message-ID: <20050908152513.GA48410@crodrigues.org> References: <20050907174535.GA1850@crodrigues.org> <20050907182059.GA13074@infradead.org> <20050907184542.GA2316@crodrigues.org> <20050908105745.GA5847@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050908105745.GA5847@infradead.org> User-Agent: Mutt/1.5.9i X-archive-position: 6090 X-ecartis-version: Ecartis v1.0.0 Sender: linux-xfs-bounce@oss.sgi.com Errors-to: linux-xfs-bounce@oss.sgi.com X-original-sender: rodrigc@crodrigues.org Precedence: bulk X-list: linux-xfs Content-Length: 568 Lines: 15 On Thu, Sep 08, 2005 at 11:57:45AM +0100, Christoph Hellwig wrote: > That was about changing them to functions, which is a) an intrusive > change and b) very debatable. Just leave the macros and remove the > whole expand the macros to out of line functions alternatively logic. > If one of them is to big we can change it to a function call later > more easily after this initial change. I don't really follow what you are looking for. Can you take one or two functions in xfs_macros.c and post an example patch? -- Craig Rodrigues rodrigc@crodrigues.org