Received: with ECARTIS (v1.0.0; list xfs); Tue, 03 Oct 2006 16:24:42 -0700 (PDT)
Received: from cuda.sgi.com (cuda2.sgi.com [192.48.168.29])
	by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id k93NOTaG024237
	for <xfs@oss.sgi.com>; Tue, 3 Oct 2006 16:24:30 -0700
X-ASG-Debug-ID: 1159914366-19034-458-0
X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi
Received: from prod.aconex.com (mail.app.aconex.com [203.89.192.138])
	by cuda.sgi.com (Spam Firewall) with ESMTP id 28482D17A48E
	for <xfs@oss.sgi.com>; Tue,  3 Oct 2006 15:26:06 -0700 (PDT)
Received: from page.mel.office.aconex.com (unknown [192.168.0.210])
	by prod.aconex.com (Postfix) with ESMTP id 6AF8028110;
	Wed,  4 Oct 2006 08:26:05 +1000 (EST)
Received: from localhost (page.mel.aconex.com [127.0.0.1])
	by page.mel.office.aconex.com (Postfix) with ESMTP
	id 521FB5340FA; Wed,  4 Oct 2006 08:26:05 +1000 (EST)
Received: from page.mel.office.aconex.com ([127.0.0.1])
 by localhost (mail.aconex.com [127.0.0.1]) (amavisd-new, port 10024)
 with LMTP id 06415-01-23; Wed,  4 Oct 2006 08:26:04 +1000 (EST)
Received: from edge (unknown [192.168.0.246])
	by page.mel.office.aconex.com (Postfix) with ESMTP
	id A6E175340F7; Wed,  4 Oct 2006 08:26:04 +1000 (EST)
X-ASG-Orig-Subj: Re: Review: clean up inode i_flags handling
Subject: Re: Review: clean up inode i_flags handling
From: Nathan Scott <nscott@aconex.com>
Reply-To: nscott@aconex.com
To: David Chinner <dgc@sgi.com>
Cc: xfs@oss.sgi.com
In-Reply-To: <20061003051325.GR4695059@melbourne.sgi.com>
References: <20061003051325.GR4695059@melbourne.sgi.com>
Content-Type: text/plain
Organization: Aconex
Date: Wed, 04 Oct 2006 08:26:13 +1000
Message-Id: <1159914373.32536.9.camel@edge>
Mime-Version: 1.0
X-Mailer: Evolution 2.6.3 
Content-Transfer-Encoding: 7bit
X-Barracuda-Spam-Score: 0.00
X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=3.5 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=9.0 tests=
X-Barracuda-Spam-Report: Code version 3.02, rules version 3.0.22498
	Rule breakdown below  pts rule name              description
	---- ---------------------- --------------------------------------------------
X-archive-position: 9163
X-ecartis-version: Ecartis v1.0.0
Sender: xfs-bounce@oss.sgi.com
Errors-to: xfs-bounce@oss.sgi.com
X-original-sender: nscott@aconex.com
Precedence: bulk
X-list: xfs

On Tue, 2006-10-03 at 15:13 +1000, David Chinner wrote:
> 

This part seems like overkill, I'd just do that inline like the clear
variant, since its just one instruction ...

+static inline void
+__xfs_iflags_set(xfs_inode_t *ip, unsigned short flags)
+{
+       ip->i_flags |= flags;
+}

Oh, ditto for the test inline func, I guess.

cheers.

-- 
Nathan