Received: with ECARTIS (v1.0.0; list xfs); Tue, 10 Jul 2007 22:53:57 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.2.0-pre1-r499012 (2007-01-23) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=AWL,BAYES_50 autolearn=no version=3.2.0-pre1-r499012 Received: from larry.melbourne.sgi.com (larry.melbourne.sgi.com [134.14.52.130]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with SMTP id l6B5rqbm025977 for ; Tue, 10 Jul 2007 22:53:54 -0700 Received: from snort.melbourne.sgi.com (snort.melbourne.sgi.com [134.14.54.149]) by larry.melbourne.sgi.com (950413.SGI.8.6.12/950213.SGI.AUTOCF) via ESMTP id PAA24618; Wed, 11 Jul 2007 15:53:49 +1000 Received: from snort.melbourne.sgi.com (localhost [127.0.0.1]) by snort.melbourne.sgi.com (SGI-8.12.5/8.12.5) with ESMTP id l6B5rneW19613240; Wed, 11 Jul 2007 15:53:49 +1000 (AEST) Received: (from dgc@localhost) by snort.melbourne.sgi.com (SGI-8.12.5/8.12.5/Submit) id l6B5rmsq19641382; Wed, 11 Jul 2007 15:53:48 +1000 (AEST) X-Authentication-Warning: snort.melbourne.sgi.com: dgc set sender to dgc@sgi.com using -f Date: Wed, 11 Jul 2007 15:53:47 +1000 From: David Chinner To: Barry Naujok Cc: "xfs@oss.sgi.com" , xfs-dev Subject: Re: REVIEW: fix xfs_bmap -vp confusion Message-ID: <20070711055347.GP12413810@sgi.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i X-Virus-Scanned: ClamAV version 0.90, clamav-milter version devel-120207 on oss.sgi.com X-Virus-Status: Clean X-archive-position: 12115 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: dgc@sgi.com Precedence: bulk X-list: xfs Status: O Content-Length: 631 Lines: 21 On Wed, Jul 11, 2007 at 01:18:20PM +1000, Barry Naujok wrote: > If xfs_bmap -vp is run on a file without unwritten extents > and the filesystem does not use sunit/swidth, the FLAGS > column is not shown. This leads to some confusion. > > So, when -vp option is used, it will always print the > FLAGS column. I note that it only prints the legend if a flag is set. I guess this is ok, but maybe it would be more consistent to always print the legend? Or even to make the legend optional (which would make dumping more than one file more compact)? Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group