Received: with ECARTIS (v1.0.0; list xfs); Fri, 13 Jul 2007 07:46:24 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.2.0-pre1-r499012 (2007-01-23) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=AWL,BAYES_50 autolearn=no version=3.2.0-pre1-r499012 Received: from pentafluge.infradead.org (pentafluge.infradead.org [213.146.154.40]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l6DEkGbm017582 for ; Fri, 13 Jul 2007 07:46:19 -0700 Received: from hch by pentafluge.infradead.org with local (Exim 4.63 #1 (Red Hat Linux)) id 1I9MPM-0006zx-Tw; Fri, 13 Jul 2007 15:46:12 +0100 Date: Fri, 13 Jul 2007 15:46:12 +0100 From: Christoph Hellwig To: "Amit K. Arora" Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, xfs@oss.sgi.com, tytso@mit.edu, cmm@us.ibm.com, suparna@in.ibm.com, adilger@clusterfs.com, dgc@sgi.com Subject: Re: [PATCH 2/6][TAKE7] fallocate() implementation in i386, x86_64 and powerpc Message-ID: <20070713144612.GA26879@infradead.org> Mail-Followup-To: Christoph Hellwig , "Amit K. Arora" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, xfs@oss.sgi.com, tytso@mit.edu, cmm@us.ibm.com, suparna@in.ibm.com, adilger@clusterfs.com, dgc@sgi.com References: <20070713123816.GA18000@amitarora.in.ibm.com> <20070713124755.GB22961@amitarora.in.ibm.com> <20070713132118.GA23256@infradead.org> <20070713141858.GB27291@amitarora.in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070713141858.GB27291@amitarora.in.ibm.com> User-Agent: Mutt/1.4.2.3i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html X-Virus-Scanned: ClamAV version 0.90, clamav-milter version devel-120207 on oss.sgi.com X-Virus-Status: Clean X-archive-position: 12162 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: hch@infradead.org Precedence: bulk X-list: xfs Status: O Content-Length: 685 Lines: 16 On Fri, Jul 13, 2007 at 07:48:58PM +0530, Amit K. Arora wrote: > Ok. Since we have only one flag (FALLOC_FL_KEEP_SIZE) and we do not want > to declare the default mode (FALLOC_ALLOCATE), we can _just_ have this > flag and remove the other mode too (FALLOC_RESV_SPACE). > Is this what you are suggesting ? Yes. > Should we need a header file just to declare one flag - i.e. > FALLOC_FL_KEEP_SIZE (since now there is no point of declaring the two > modes) ? If "linux/fs.h" is not a good place, will "asm-generic/fcntl.h" > be a sane place for this flag ? It might sound a litte silly but is the cleanest thing we could do by far. And I suspect there will be more more flags soon..