Received: with ECARTIS (v1.0.0; list xfs); Tue, 05 Feb 2008 20:59:18 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.0-r574664 (2007-09-11) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.0-r574664 Received: from cuda.sgi.com (cuda2.sgi.com [192.48.168.29]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id m164x5RS023720 for ; Tue, 5 Feb 2008 20:59:08 -0800 X-ASG-Debug-ID: 1202273735-510900230000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 4CF355A566F; Tue, 5 Feb 2008 20:55:35 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id 6G8K0iz6kUf8KrDh; Tue, 05 Feb 2008 20:55:35 -0800 (PST) Received: from hch by bombadil.infradead.org with local (Exim 4.68 #1 (Red Hat Linux)) id 1JMcJo-0004rB-2c; Wed, 06 Feb 2008 04:55:32 +0000 Date: Tue, 5 Feb 2008 23:55:32 -0500 From: Christoph Hellwig To: David Chinner Cc: Sven Geggus , xfs@oss.sgi.com, Tobias Ulmer , Andrea Perotti X-ASG-Orig-Subj: Re: [PATCH] Possible fix for 2.6.24 xfs_file_readdir crash Subject: Re: [PATCH] Possible fix for 2.6.24 xfs_file_readdir crash Message-ID: <20080206045532.GA16437@infradead.org> References: <20080205052418.GU155259@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080205052418.GU155259@sgi.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-Barracuda-Connect: bombadil.infradead.org[18.85.46.34] X-Barracuda-Start-Time: 1202273738 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=3.0 tests= X-Barracuda-Spam-Report: Code version 3.1, rules version 3.1.41481 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV 0.91.2/5704/Tue Feb 5 18:30:27 2008 on oss.sgi.com X-Virus-Status: Clean X-archive-position: 14356 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: hch@infradead.org Precedence: bulk X-list: xfs Looks good to me. Well not really good but like fixing the corner case. We really need to get rid of this stupid loop. I'll put fixing nfsd up higher in my todo list.