Received: with ECARTIS (v1.0.0; list xfs); Sun, 04 May 2008 22:54:22 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.0-r574664 (2007-09-11) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-r574664 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.168.28]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id m455s4s6020570 for ; Sun, 4 May 2008 22:54:05 -0700 X-ASG-Debug-ID: 1209966886-397b01120000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 0AE8EB00B96; Sun, 4 May 2008 22:54:46 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id 0d1QAWK2HRIwxC5j; Sun, 04 May 2008 22:54:46 -0700 (PDT) Received: from hch by bombadil.infradead.org with local (Exim 4.68 #1 (Red Hat Linux)) id 1Jstew-00054b-JX; Mon, 05 May 2008 05:54:46 +0000 Date: Mon, 5 May 2008 01:54:46 -0400 From: Christoph Hellwig To: Timothy Shimmin Cc: xfs-dev , xfs-oss X-ASG-Orig-Subj: Re: review: xfstests/016 change Subject: Re: review: xfstests/016 change Message-ID: <20080505055446.GB15609@infradead.org> References: <481E7F17.5090601@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <481E7F17.5090601@sgi.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-Barracuda-Connect: bombadil.infradead.org[18.85.46.34] X-Barracuda-Start-Time: 1209966890 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.1, rules version 3.1.49697 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV 0.91.2/6021/Wed Feb 27 15:55:48 2008 on oss.sgi.com X-Virus-Status: Clean X-archive-position: 15775 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: hch@infradead.org Precedence: bulk X-list: xfs On Mon, May 05, 2008 at 01:29:27PM +1000, Timothy Shimmin wrote: > Hi there, > > xfstests/016 has been failing for a while in many cases. > It was relying on the log traffic for create/rm to be unaltered > in XFS over the life of XFS. > Its initial purpose was to test out the writing of the log around > wrapping and checking that as we wrapped we didn't corrupt any data > after the end of the log. > > The patch is to modify xfstest, 016, to take a sampling of the log traffic > to guestimate how many ops are needed to get to the end of the log, > instead of hard-coding in how many ops are expected to get there. I get four rejects out of four hunk when trying to apply this patch, looks like whitespace-damage.