Received: with ECARTIS (v1.0.0; list xfs); Thu, 26 Jun 2008 06:06:01 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.0-r574664 (2007-09-11) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.3.0-r574664 Received: from cuda.sgi.com ([192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id m5QD5xpD023893 for ; Thu, 26 Jun 2008 06:06:00 -0700 X-ASG-Debug-ID: 1214485620-130403250000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id DC2FF182C03B for ; Thu, 26 Jun 2008 06:07:00 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id bXuo455AIIrDlTBA for ; Thu, 26 Jun 2008 06:07:00 -0700 (PDT) Received: from hch by bombadil.infradead.org with local (Exim 4.68 #1 (Red Hat Linux)) id 1KBrBk-0002H3-LR; Thu, 26 Jun 2008 13:07:00 +0000 Date: Thu, 26 Jun 2008 09:07:00 -0400 From: Christoph Hellwig To: Christoph Hellwig , xfs@oss.sgi.com, matthew@wil.cx, linux-kernel@vger.kernel.org X-ASG-Orig-Subj: Re: [PATCH 1/6] Extend completions to provide XFS object flush requirements Subject: Re: [PATCH 1/6] Extend completions to provide XFS object flush requirements Message-ID: <20080626130700.GA24325@infradead.org> References: <1214455277-6387-1-git-send-email-david@fromorbit.com> <1214455277-6387-2-git-send-email-david@fromorbit.com> <20080626074636.GB7064@infradead.org> <20080626112133.GJ11558@disturbed> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080626112133.GJ11558@disturbed> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-Barracuda-Connect: bombadil.infradead.org[18.85.46.34] X-Barracuda-Start-Time: 1214485620 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: 0.86 X-Barracuda-Spam-Status: No, SCORE=0.86 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=RATWARE_EFROM X-Barracuda-Spam-Report: Code version 3.1, rules version 3.1.54391 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 2.88 RATWARE_EFROM Bulk email fingerprint (envfrom) found X-Virus-Scanned: ClamAV 0.91.2/6021/Wed Feb 27 15:55:48 2008 on oss.sgi.com X-Virus-Status: Clean X-archive-position: 16576 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: hch@infradead.org Precedence: bulk X-list: xfs On Thu, Jun 26, 2008 at 09:21:33PM +1000, Dave Chinner wrote: > Ok, so that involves exactly what? A new header file, a new API name > (ideas anyone?) and kerneldoc comments? Yes, probably just a new header with properly documented functions. Thew two non-trivial ones you added should probably not be inlines, btw. flush_lock_init/flush_lock/flush_trylock/flush_done/flush_is_locked?