X-Spam-Checker-Version: SpamAssassin 3.3.0-r574664 (2007-09-11) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.0-r574664 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.168.28]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id m8DGvRgX004007 for ; Sat, 13 Sep 2008 09:57:27 -0700 X-ASG-Debug-ID: 1221325137-649602df0000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from josefsipek.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 25B95126C5F2 for ; Sat, 13 Sep 2008 09:58:57 -0700 (PDT) Received: from josefsipek.net (josefsipek.net [141.211.133.196]) by cuda.sgi.com with ESMTP id tO0ZkqDcT6f88RtE for ; Sat, 13 Sep 2008 09:58:57 -0700 (PDT) Received: by josefsipek.net (Postfix, from userid 1000) id B5BB81C00DDE; Sat, 13 Sep 2008 12:58:56 -0400 (EDT) Date: Sat, 13 Sep 2008 12:58:56 -0400 From: "Josef 'Jeff' Sipek" To: Dave Chinner Cc: xfs@oss.sgi.com X-ASG-Orig-Subj: Re: [PATCH 05/10] XFS: xfssyncd: don't call xfs_sync Subject: Re: [PATCH 05/10] XFS: xfssyncd: don't call xfs_sync Message-ID: <20080913165856.GB17721@josefsipek.net> References: <1221314230-28618-1-git-send-email-david@fromorbit.com> <1221314230-28618-6-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1221314230-28618-6-git-send-email-david@fromorbit.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-Barracuda-Connect: josefsipek.net[141.211.133.196] X-Barracuda-Start-Time: 1221325138 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.5467 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- On Sat, Sep 13, 2008 at 11:57:05PM +1000, Dave Chinner wrote: ... > @@ -533,8 +538,15 @@ xfs_sync_worker( > { > int error; > > - if (!(mp->m_flags & XFS_MOUNT_RDONLY)) > - error = xfs_sync(mp, SYNC_FSDATA | SYNC_BDFLUSH | SYNC_ATTR); > + if (!(mp->m_flags & XFS_MOUNT_RDONLY)) { > + xfs_log_force(mp, (xfs_lsn_t)0, XFS_LOG_FORCE); > + xfs_finish_reclaim_all(mp, 1, XFS_IFLUSH_DELWRI_ELSE_ASYNC); > + /* dgc: errors ignored here */ Again, why? > + error = XFS_QM_DQSYNC(mp, SYNC_BDFLUSH); > + error = xfs_sync_fsdata(mp, SYNC_BDFLUSH); > + if (xfs_log_need_covered(mp)) > + error = xfs_commit_dummy_trans(mp, XFS_LOG_FORCE); > + } > mp->m_sync_seq++; > wake_up(&mp->m_wait_single_sync_task); > } Josef 'Jeff' Sipek. -- I'm somewhere between geek and normal. - Linus Torvalds