Date: Wed, 22 Oct 2008 07:36:13 +1100
From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com
Subject: Re: [PATCH 1/3] stop using xfs_itobp in xfs_bulkstat
Message-ID: <20081021203612.GL25906@disturbed>
Mail-Followup-To: Christoph Hellwig <hch@infradead.org>,
	Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com
References: <20081020222036.GA23662@lst.de> <20081021024455.GB18495@disturbed> <20081021081329.GA23344@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081021081329.GA23344@infradead.org>
User-Agent: Mutt/1.5.18 (2008-05-17)

On Tue, Oct 21, 2008 at 04:13:29AM -0400, Christoph Hellwig wrote:
> On Tue, Oct 21, 2008 at 01:44:55PM +1100, Dave Chinner wrote:
> > On Tue, Oct 21, 2008 at 12:20:36AM +0200, Christoph Hellwig wrote:
> > > xfs_bulkstat only wants the dinode, offset and buffer from a given
> > > inode number.  Instead of using xfs_itobp on a fake inode that is much
> > > easier done with xfs_inotobp, which just needs an imap_flag paramter to
> > > pass down the XFS_IMAP_BULKSTAT flag.
> > 
> > Nice - that removes the only external user of xfs_inode_alloc() very
> > cleanly. Looks ok to me.
> 
> Which means we should mark it static now.  Updated patch below:

Looks good.

BTW, the original patch series has run through xfsqa on my setup
overnight without any problems.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com