X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id mAQA5HCZ002321 for ; Wed, 26 Nov 2008 04:05:17 -0600 X-ASG-Debug-ID: 1227693916-19d100610000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id D024F16046B4 for ; Wed, 26 Nov 2008 02:05:16 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id HRu1XKcB0R9Humji for ; Wed, 26 Nov 2008 02:05:16 -0800 (PST) X-ASG-Whitelist: Client Received: from hch by bombadil.infradead.org with local (Exim 4.68 #1 (Red Hat Linux)) id 1L5HGm-0000Jk-IF; Wed, 26 Nov 2008 10:05:16 +0000 Date: Wed, 26 Nov 2008 05:05:16 -0500 From: Christoph Hellwig To: sandeen@sandeen.net Cc: xfs@oss.sgi.com X-ASG-Orig-Subj: Re: [patch 02/12] Move compat ioctl structs & numbers into xfs_ioctl32.h Subject: Re: [patch 02/12] Move compat ioctl structs & numbers into xfs_ioctl32.h Message-ID: <20081126100516.GB31114@infradead.org> References: <20081126032005.639750968@sandeen.net> <20081126032027.099506160@sandeen.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081126032027.099506160@sandeen.net> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-Barracuda-Connect: bombadil.infradead.org[18.85.46.34] X-Barracuda-Start-Time: 1227693916 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com On Tue, Nov 25, 2008 at 09:20:07PM -0600, sandeen@sandeen.net wrote: > This makes the c file less cluttered and a bit more > readable. Consistently name the ioctl number > macros with "_32" and the compatibility stuctures > with "_compat." Rename the helpers which simply > copy in the arg with "_copyin" for easy identification. > > Finally, for a few of the existing helpers, modify them > so that they directly call the native ioctl helper > after userspace argument fixup. Looks good.