X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.6 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from oss.sgi.com (localhost [127.0.0.1]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0M4hc6m040284 for ; Wed, 21 Jan 2009 22:43:38 -0600 Received: (from felixb@localhost) by oss.sgi.com (8.14.3/8.14.3/Submit) id n0M4haK2040249; Wed, 21 Jan 2009 22:43:36 -0600 Date: Wed, 21 Jan 2009 22:43:36 -0600 Message-Id: <200901220443.n0M4haK2040249@oss.sgi.com> From: xfs@oss.sgi.com To: xfs@oss.sgi.com Subject: [XFS updates] XFS development tree branch, master, updated. v2.6.28-rc3-11564-g957274d X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 5253a11a8187b6329dda41219d9eece971c06e19 X-Git-Newrev: 957274d7ce39eb9dab3666fc5c9f634c4d9fbf9d This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "XFS development tree". The branch, master has been updated 957274d Merge branch 'master' of git+ssh://oss.sgi.com/oss/git/xfs/xfs 33ad965 Long btree pointers are still 64 bit on disk from 5253a11a8187b6329dda41219d9eece971c06e19 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 957274d7ce39eb9dab3666fc5c9f634c4d9fbf9d Merge: 33ad965dde197a016083438359c3163e1aca9ada 5253a11a8187b6329dda41219d9eece971c06e19 Author: Felix Blyakher Date: Wed Jan 21 22:39:29 2009 -0600 Merge branch 'master' of git+ssh://oss.sgi.com/oss/git/xfs/xfs commit 33ad965dde197a016083438359c3163e1aca9ada Author: Dave Chinner Date: Wed Jan 21 15:22:17 2009 +1100 Long btree pointers are still 64 bit on disk [XFS] Long btree pointers are still 64 bit on disk On 32 bit machines with CONFIG_LBD=n, XFS reduces the in memory size of xfs_fsblock_t to 32 bits so that it will fit within 32 bit addressing. However, the disk format for long btree pointers are still 64 bits in size. The recent btree rewrite failed to take this into account when initialising new btree blocks, setting sibling pointers to NULL and checking if they are NULL. Hence checking whether a 64 bit NULL was the same as a 32 bit NULL was failingi resulting in NULL sibling pointers failing to be detected correctly. This showed up as WANT_CORRUPTED_GOTO shutdowns in xfs_btree_delrec. Fix this by making all the comparisons and setting of long pointer btree NULL blocks to the disk format, not the in memory format. i.e. use NULLDFSBNO. Reported-by: Alexander Beregalov Reported-by: Jacek Luczak Reported-by: Danny ter Haar Tested-by: Jacek Luczak Reviewed-by: Christoph Hellwig Signed-off-by: Dave Chinner Signed-off-by: Felix Blyakher ----------------------------------------------------------------------- Summary of changes: fs/xfs/xfs_btree.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) hooks/post-receive -- XFS development tree