X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n53HIlTH185701 for ; Wed, 3 Jun 2009 12:18:47 -0500 X-ASG-Debug-ID: 1244049544-765b03700000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 4C6E91BC8AE0 for ; Wed, 3 Jun 2009 10:19:04 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id sXnjmPHY5OaaXma7 for ; Wed, 03 Jun 2009 10:19:04 -0700 (PDT) X-ASG-Whitelist: Client Received: from hch by bombadil.infradead.org with local (Exim 4.69 #1 (Red Hat Linux)) id 1MBu7E-0000Ee-EU; Wed, 03 Jun 2009 17:19:04 +0000 Date: Wed, 3 Jun 2009 13:19:04 -0400 From: Christoph Hellwig To: Eric Sandeen Cc: xfs mailing list X-ASG-Orig-Subj: Re: [PATCH] xfstests: Make the SCRATCH_DEV optional Subject: Re: [PATCH] xfstests: Make the SCRATCH_DEV optional Message-ID: <20090603171904.GA22100@infradead.org> References: <4A26AC60.6060401@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A26AC60.6060401@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-Barracuda-Connect: bombadil.infradead.org[18.85.46.34] X-Barracuda-Start-Time: 1244049545 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Wed, Jun 03, 2009 at 12:01:20PM -0500, Eric Sandeen wrote: > Tests will fail gracefully if there is no SCRATCH_DEV defined, so change > > the check script to allow it, and update README to reflect this. > > This just makes it simpler to set up the tests, at the expense of > coverage. > > Long term it might be nice to allow either SCRATCH_DEV xor TEST_DEV > to be missing, but for now this is simple. Looks good, Reviewed-by: Christoph Hellwig