X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n58GQir3237587 for ; Mon, 8 Jun 2009 11:26:44 -0500 X-ASG-Debug-ID: 1244478844-3d28003b0000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mx2.redhat.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 08FE5148FE84 for ; Mon, 8 Jun 2009 09:34:04 -0700 (PDT) Received: from mx2.redhat.com (mx2.redhat.com [66.187.237.31]) by cuda.sgi.com with ESMTP id owQAn5u7wXs88FSY for ; Mon, 08 Jun 2009 09:34:04 -0700 (PDT) Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n58GQscN023085; Mon, 8 Jun 2009 12:26:54 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n58GQrNs017273; Mon, 8 Jun 2009 12:26:53 -0400 Received: from neon.msp.redhat.com (neon.msp.redhat.com [10.15.80.10]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n58GQqiu032347; Mon, 8 Jun 2009 12:26:53 -0400 Message-ID: <4A2D3BCC.2010000@sandeen.net> Date: Mon, 08 Jun 2009 11:26:52 -0500 From: Eric Sandeen User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Christoph Hellwig CC: xfs mailing list X-ASG-Orig-Subj: Re: [PATCH] xfstests: Allow fsx tests to run on generic filesystems Subject: Re: [PATCH] xfstests: Allow fsx tests to run on generic filesystems References: <4A2D31E3.3090108@sandeen.net> <20090608161646.GA14861@infradead.org> In-Reply-To: <20090608161646.GA14861@infradead.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 X-Barracuda-Connect: mx2.redhat.com[66.187.237.31] X-Barracuda-Start-Time: 1244478845 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.42 X-Barracuda-Spam-Status: No, SCORE=-1.42 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=MARKETING_SUBJECT X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.359 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.60 MARKETING_SUBJECT Subject contains popular marketing words X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean Christoph Hellwig wrote: > On Mon, Jun 08, 2009 at 10:44:35AM -0500, Eric Sandeen wrote: >> There is already logic in 075 to gracefully skip nfs for fsx >> invocations with -x (xfs-specific preallocation) - just extend >> this to any non-xfs filesystem, and add to test 112 as well. >> >> Later we can change this behavior to use fallocate and include >> more filesystems but this gets some fsx coverage for now. >> >> Test 127 doesn't seem to have anything xfs-specific, so mark >> that as generic too. > > Good bandaid for now, but it would be even better to get a fsx > version using the generic prealloc calls one day :) Will do after we're done w/ the planned fsx gyrations.... -Eric > Reviewed-by: Christoph Hellwig >