X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n83KuB4a131539 for ; Thu, 3 Sep 2009 15:56:21 -0500 Received: from goalpost.americas.sgi.com (goalpost.americas.sgi.com [128.162.232.54]) by relay1.corp.sgi.com (Postfix) with ESMTP id E36E58F8049 for ; Thu, 3 Sep 2009 13:57:08 -0700 (PDT) Received: by goalpost.americas.sgi.com (Postfix, from userid 14442) id 9127F2526DDC; Thu, 3 Sep 2009 15:49:40 -0500 (CDT) Date: Thu, 3 Sep 2009 15:49:40 -0500 From: Geoffrey Wehrman To: Christoph Hellwig Cc: xfs@oss.sgi.com Subject: Re: [PATCH 00/14] repair memory usage reductions Message-ID: <20090903204940.GB24510@sgi.com> References: <20090902175531.469184575@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090902175531.469184575@bombadil.infradead.org> User-Agent: Mutt/1.5.14 (2007-02-12) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Wed, Sep 02, 2009 at 01:55:31PM -0400, Christoph Hellwig wrote: | This is a respin of the patches Barry Naujok wrote at SGI for reducing | the memory usage in repair. I've split it up, fixed a few small bugs | and added two preparatory cleanups - but all the real work is Barry's. | There has been lots of heavy testing on large filesystems by Barry | on the original patches, and quite a lot of testing on slightly smaller | filesystems by me. These were all ad-hoc tests as XFSQA coverage is | rather low on repair. My plan is to add various additional testcase | for XFSQA both for intentional corruptions as well as reproducing past | reported bugs before we'll release these patches in xfsprogs. But I think | it would be good if we could get them into the development git tree to | get wider coverage already. How do these changes affect xfs_repair I/O performance? Barry changes were previously withheld within SGI due to a regression in performance. -- Geoffrey Wehrman 651-683-5496 gwehrman@sgi.com