X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id nBV9ZJ9V117811 for ; Thu, 31 Dec 2009 03:35:19 -0600 X-ASG-Debug-ID: 1262252167-20ce01870000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 8ECD910CD083; Thu, 31 Dec 2009 01:36:07 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id f6MVbRAkSUzidDEb; Thu, 31 Dec 2009 01:36:07 -0800 (PST) X-ASG-Whitelist: Client Received: from hch by bombadil.infradead.org with local (Exim 4.69 #1 (Red Hat Linux)) id 1NQHRs-0007na-G5; Thu, 31 Dec 2009 09:36:04 +0000 Date: Thu, 31 Dec 2009 04:36:04 -0500 From: Christoph Hellwig To: Li Zefan Cc: Alex Elder , Christoph Hellwig , xfs@oss.sgi.com, Ingo Molnar , Steven Rostedt , Frederic Weisbecker , LKML X-ASG-Orig-Subj: Re: [PATCH] xfs: Convert some trace events to DEFINE_TRACE Subject: Re: [PATCH] xfs: Convert some trace events to DEFINE_TRACE Message-ID: <20091231093604.GA29917@infradead.org> References: <4B3C64D4.3060706@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B3C64D4.3060706@cn.fujitsu.com> User-Agent: Mutt/1.5.19 (2009-01-05) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-Barracuda-Connect: bombadil.infradead.org[18.85.46.34] X-Barracuda-Start-Time: 1262252167 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Thu, Dec 31, 2009 at 04:46:12PM +0800, Li Zefan wrote: > Use DECLARE_EVENT_CLASS/DEFINE_EVENT to remove duplicate code: > > text data bss dec hex filename > 871963 35416 3612 910991 de68f fs/xfs/xfs.o.orig > 575027 35416 3404 613847 95dd7 fs/xfs/xfs.o > > To test this patch, I compared the format files of trace events, > before and after patching: I already sent this patch a long time ago, still waiting for Alex to pick it up.