X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0E0kiRe205369 for ; Wed, 13 Jan 2010 18:46:44 -0600 X-ASG-Debug-ID: 1263430058-74f301610000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id A37CE16447B for ; Wed, 13 Jan 2010 16:47:39 -0800 (PST) Received: from mail.internode.on.net (bld-mail18.adl2.internode.on.net [150.101.137.103]) by cuda.sgi.com with ESMTP id coYZYFjX20XNUDcR for ; Wed, 13 Jan 2010 16:47:39 -0800 (PST) Received: from discord (unverified [121.44.236.168]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 11511478-1927428 for multiple; Thu, 14 Jan 2010 11:17:38 +1030 (CDT) Received: from dave by discord with local (Exim 4.69) (envelope-from ) id 1NVDs8-0007JU-LS; Thu, 14 Jan 2010 11:47:36 +1100 Date: Thu, 14 Jan 2010 11:47:36 +1100 From: Dave Chinner To: Christoph Hellwig Cc: xfs@oss.sgi.com X-ASG-Orig-Subj: Re: [PATCH 1/3] xfs: kill XFS_QMOPT_ASYNC Subject: Re: [PATCH 1/3] xfs: kill XFS_QMOPT_ASYNC Message-ID: <20100114004736.GT17483@discord.disaster> References: <20100113220547.846700560@bombadil.infradead.org> <20100113220602.632551077@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100113220602.632551077@bombadil.infradead.org> User-Agent: Mutt/1.5.18 (2008-05-17) X-Barracuda-Connect: bld-mail18.adl2.internode.on.net[150.101.137.103] X-Barracuda-Start-Time: 1263430060 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.19730 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Wed, Jan 13, 2010 at 05:05:48PM -0500, Christoph Hellwig wrote: > The option is unused and one of the few remaining users of xfs_bawrite, > so let's get rid of it. > > Signed-off-by: Christoph Hellwig Looks good. Reviewed-by: Dave Chinner FWIW, I've got a bigger patch that kills off all three QMOPT writeback flags, but it isn't quite ready yet... Cheers, Dave. -- Dave Chinner david@fromorbit.com