X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX,J_CHICKENPOX_43 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0J13lec143936 for ; Mon, 18 Jan 2010 19:03:47 -0600 X-ASG-Debug-ID: 1263863085-4e9100aa0000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 7F6A211F8D1E for ; Mon, 18 Jan 2010 17:04:46 -0800 (PST) Received: from mail.internode.on.net (bld-mail16.adl2.internode.on.net [150.101.137.101]) by cuda.sgi.com with ESMTP id mk8S1cyHOYwNDQry for ; Mon, 18 Jan 2010 17:04:46 -0800 (PST) Received: from discord (unverified [121.44.156.64]) by mail.internode.on.net (SurgeMail 3.8f2) with ESMTP id 11543199-1927428 for multiple; Tue, 19 Jan 2010 11:34:45 +1030 (CDT) Received: from dave by discord with local (Exim 4.69) (envelope-from ) id 1NX2WR-0003Hf-OR; Tue, 19 Jan 2010 12:04:43 +1100 Date: Tue, 19 Jan 2010 12:04:43 +1100 From: Dave Chinner To: Eric Sandeen Cc: xfs-oss X-ASG-Orig-Subj: Re: [PATCH] mkfs: don't warn about topology when mkfsing a file Subject: Re: [PATCH] mkfs: don't warn about topology when mkfsing a file Message-ID: <20100119010443.GK7264@discord.disaster> References: <4B54B4D1.7020500@sandeen.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B54B4D1.7020500@sandeen.net> User-Agent: Mutt/1.5.18 (2008-05-17) X-Barracuda-Connect: bld-mail16.adl2.internode.on.net[150.101.137.101] X-Barracuda-Start-Time: 1263863087 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.20188 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Mon, Jan 18, 2010 at 01:21:53PM -0600, Eric Sandeen wrote: > Some tests were failing for me like: > > QA output created by 206 > === truncate file === > === mkfs.xfs === > +warning: unable to probe device toplology for device /mnt/test/fsfile.21615 > ... > > I thought about filtering the tests, but ... > > It seems that we shouldn't even be trying to get topology for a > plain file, should we? And then we won't warn about failure. > > > Signed-off-by: Eric Sandeen Sound pretty sane to me. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com