X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0LBNPk7068668 for ; Thu, 21 Jan 2010 05:23:25 -0600 X-ASG-Debug-ID: 1264073066-4b6c02e90000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id F3DB91C6A5F6 for ; Thu, 21 Jan 2010 03:24:26 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id FATX9QUY27l3y5i6 for ; Thu, 21 Jan 2010 03:24:26 -0800 (PST) X-ASG-Whitelist: Client Received: from hch by bombadil.infradead.org with local (Exim 4.69 #1 (Red Hat Linux)) id 1NXv9G-0007yl-MC; Thu, 21 Jan 2010 11:24:26 +0000 Date: Thu, 21 Jan 2010 06:24:26 -0500 From: Christoph Hellwig To: Dave Chinner Cc: xfs@oss.sgi.com X-ASG-Orig-Subj: Re: [PATCH 2/2] xfstests: Automatic build dependency calculations Subject: Re: [PATCH 2/2] xfstests: Automatic build dependency calculations Message-ID: <20100121112426.GB27634@infradead.org> References: <1264053773-6054-1-git-send-email-david@fromorbit.com> <1264053773-6054-3-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1264053773-6054-3-git-send-email-david@fromorbit.com> User-Agent: Mutt/1.5.19 (2009-01-05) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-Barracuda-Connect: bombadil.infradead.org[18.85.46.34] X-Barracuda-Start-Time: 1264073067 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean > LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize \ > - preallo_rw_pattern_reader preallo_rw_pattern_writer ftrunc trunc \ > - fs_perms testx looptest locktest unwritten_mmap \ > + ftrunc trunc fs_perms testx looptest locktest unwritten_mmap \ > bulkstat_unlink_test bulkstat_unlink_test_modified t_dir_offset \ > t_futimens > > +SUBDIRS = > + > LLDLIBS = $(LIBATTR) $(LIBHANDLE) $(LIBACL) > > ifeq ($(HAVE_XLOG_ASSIGN_LSN), true) > @@ -27,6 +28,7 @@ endif > IRIX_TARGETS = open_unlink > > ifeq ($(PKG_PLATFORM),linux) > +PREALLO_TARGETS = preallo_rw_pattern_reader What happens to the writer here? Before introducing more special cases for this duplicates let me post my patch to make the file compiled more normal, will send it out ASAP. Otherwise looks good to me.