X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o1H2bp57199183 for ; Tue, 16 Feb 2010 20:37:52 -0600 X-ASG-Debug-ID: 1266374349-43d602c60000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from fieldses.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 0E6E21D76EB; Tue, 16 Feb 2010 18:39:09 -0800 (PST) Received: from fieldses.org (fieldses.org [174.143.236.118]) by cuda.sgi.com with ESMTP id 8UkQSxvC5HNN6qFO; Tue, 16 Feb 2010 18:39:09 -0800 (PST) Received: from bfields by fieldses.org with local (Exim 4.69) (envelope-from ) id 1NhZpM-000074-TY; Tue, 16 Feb 2010 21:39:48 -0500 Date: Tue, 16 Feb 2010 21:39:48 -0500 From: "J. Bruce Fields" To: Ben Myers Cc: linux-nfs@vger.kernel.org, xfs@oss.sgi.com X-ASG-Orig-Subj: Re: [PATCH 0/2] commit_metadata export operation v5 Subject: Re: [PATCH 0/2] commit_metadata export operation v5 Message-ID: <20100217023948.GB32315@fieldses.org> References: <20100216210026.5694.14423.stgit@case> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100216210026.5694.14423.stgit@case> User-Agent: Mutt/1.5.18 (2008-05-17) X-Barracuda-Connect: fieldses.org[174.143.236.118] X-Barracuda-Start-Time: 1266374350 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.22734 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Tue, Feb 16, 2010 at 03:04:08PM -0600, Ben Myers wrote: > Here is the latest version of the knfsd sync changes that I've been spamming > you with. Don't worry about spamming--it's good that people have lots of comments! --b. > I have addressed the latest suggestions provided by Christoph, > Trond, Dave, and Alex. This version of the commit_metadata export operation > takes only one inode as suggested by Christoph and it turns out to be much > cleaner this way. Now we've gone back to committing all of the time in > nfsd_create_setattr and don't bother with the added argument. A couple extra > comments to explain the commit ordering. > > Thanks, > Ben > > --- > > Ben Myers (2): > commit_metadata export operation replacing nfsd_sync_dir > xfs_export_operations.commit_metadata > > > fs/nfsd/nfs4recover.c | 4 -- > fs/nfsd/vfs.c | 109 ++++++++++++++++++++--------------------- > fs/xfs/linux-2.6/xfs_export.c | 24 +++++++++ > include/linux/exportfs.h | 5 ++ > 4 files changed, 83 insertions(+), 59 deletions(-) > > --