X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=AWL,BAYES_00,FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o36NvQo9145336 for ; Tue, 6 Apr 2010 18:57:27 -0500 X-ASG-Debug-ID: 1270598355-53f701f60000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from postoffice2.aconex.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 08AE91D3D970 for ; Tue, 6 Apr 2010 16:59:16 -0700 (PDT) Received: from postoffice2.aconex.com (mail.aconex.com [203.89.202.182]) by cuda.sgi.com with ESMTP id 38RTHVrK4Dn54rdp for ; Tue, 06 Apr 2010 16:59:16 -0700 (PDT) Received: from postoffice.aconex.com (localhost [127.0.0.1]) by postoffice2.aconex.com (Spam & Virus Firewall) with ESMTP id CC1938A75B8; Wed, 7 Apr 2010 09:59:13 +1000 (EST) Received: from postoffice.aconex.com (postoffice.yarra.acx [192.168.102.1]) by postoffice2.aconex.com with ESMTP id aWPE7PanAvaRqAV5; Wed, 07 Apr 2010 09:59:13 +1000 (EST) Received: from gatekeeper.aconex.com (gatekeeper.yarra.acx [192.168.102.10]) by postoffice.aconex.com (Postfix) with ESMTP id 62560A50296; Wed, 7 Apr 2010 09:56:16 +1000 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gatekeeper.aconex.com (Postfix) with ESMTP id 9961B4883EA; Wed, 7 Apr 2010 09:59:13 +1000 (EST) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: amavisd-new at aconex.com Received: from gatekeeper.aconex.com ([127.0.0.1]) by localhost (gatekeeper.aconex.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z3DbQkjNTD8w; Wed, 7 Apr 2010 09:59:08 +1000 (EST) Received: from mail-au.aconex.com (mail-au.aconex.com [192.168.102.12]) by gatekeeper.aconex.com (Postfix) with ESMTP id CBB07488573; Wed, 7 Apr 2010 09:59:08 +1000 (EST) Date: Wed, 7 Apr 2010 09:59:08 +1000 (EST) From: Nathan Scott To: Christoph Hellwig Cc: xfs@oss.sgi.com Message-ID: <1369590830.403251270598348701.JavaMail.root@mail-au.aconex.com> In-Reply-To: <20100403103321.GA20739@infradead.org> X-ASG-Orig-Subj: Re: [PATCH] xfsprogs: add a platform_discard_blocks stub to gnufreebsd Subject: Re: [PATCH] xfsprogs: add a platform_discard_blocks stub to gnufreebsd MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [203.89.192.141] X-Mailer: Zimbra 5.0.18_GA_3011.RHEL5_64 (ZimbraWebClient - FF3.0 (Linux)/5.0.18_GA_3011.RHEL5_64) X-Barracuda-Connect: mail.aconex.com[203.89.202.182] X-Barracuda-Start-Time: 1270598357 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0247 1.0000 -1.8608 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.86 X-Barracuda-Spam-Status: No, SCORE=-1.86 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.26884 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean ----- "Christoph Hellwig" wrote: > Signed-off-by: Christoph Hellwig > > Index: xfsprogs-dev/include/gnukfreebsd.h > =================================================================== > --- xfsprogs-dev.orig/include/gnukfreebsd.h 2010-04-03 > 12:29:57.048004157 +0200 > +++ xfsprogs-dev/include/gnukfreebsd.h 2010-04-03 12:30:12.913005989 > +0200 > @@ -119,4 +119,10 @@ static __inline__ void platform_uuid_cop > uuid_copy(*dst, *src); > } > > +static __inline__ int > +platform_discard_blocks(int fd, uint64_t start, uint64_t len) > +{ > + return 0; > +} > + > #endif /* __XFS_KFREEBSD_H__ */ > Looks good to me, thanks Christoph. -- Nathan