X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p0AJGGH8032837 for ; Mon, 10 Jan 2011 13:16:16 -0600 X-ASG-Debug-ID: 1294687108-0c5d00a50000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id C88C01D1FC0D for ; Mon, 10 Jan 2011 11:18:28 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id WP1rVZdDZODL2cDw for ; Mon, 10 Jan 2011 11:18:28 -0800 (PST) X-ASG-Whitelist: Client Received: from hch by bombadil.infradead.org with local (Exim 4.72 #1 (Red Hat Linux)) id 1PcNG6-0006b4-EY; Mon, 10 Jan 2011 19:18:26 +0000 Date: Mon, 10 Jan 2011 14:18:26 -0500 From: Christoph Hellwig To: Michael Monnerie Cc: xfs@oss.sgi.com X-ASG-Orig-Subj: Re: [PATCH] xfs_repair: multithread phase 2 Subject: Re: [PATCH] xfs_repair: multithread phase 2 Message-ID: <20110110191826.GB25029@infradead.org> References: <1294620248-17098-1-git-send-email-david@fromorbit.com> <201101100857.53421@zmi.at> <20110110084122.GF28803@dastard> <201101101425.48134@zmi.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201101101425.48134@zmi.at> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-Barracuda-Connect: bombadil.infradead.org[18.85.46.34] X-Barracuda-Start-Time: 1294687108 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Mon, Jan 10, 2011 at 02:25:47PM +0100, Michael Monnerie wrote: > On Montag, 10. Januar 2011 Dave Chinner wrote: > > Pretty much > > every sata disk supports NCQ these days, and default to a depth of > > 32, which means we can have 32 concurrent reads in progress at once. > > Phase 2 is all synchronous IO, so the only way to hide the IO > > latency is to queue work to multiple threads and switch between the > > threadsto work on another queue when the current one blocks waiting > > for IO. > > This is interesting. Did you measure this with a rotating single disk? Take a look at the patch description.