X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p65MZNPM044649 for ; Tue, 5 Jul 2011 17:35:23 -0500 Received: from cas.corp.sgi.com (pv-excas1-dc21-nlb.corp.sgi.com [137.38.102.126]) by relay1.corp.sgi.com (Postfix) with ESMTP id A0F4D8F804B; Tue, 5 Jul 2011 15:35:20 -0700 (PDT) Received: from [127.0.0.1] (128.162.232.50) by xmail.sgi.com (137.38.102.30) with Microsoft SMTP Server (TLS) id 14.1.289.1; Tue, 5 Jul 2011 17:35:20 -0500 Subject: Re: [PATCH 02/27] xfs: re-enable non-blocking behaviour in xfs_map_blocks From: Alex Elder Reply-To: To: Christoph Hellwig CC: In-Reply-To: <20110701094602.465074143@bombadil.infradead.org> References: <20110701094321.936534538@bombadil.infradead.org> <20110701094602.465074143@bombadil.infradead.org> Content-Type: text/plain; charset="UTF-8" Date: Tue, 5 Jul 2011 17:35:19 -0500 Message-ID: <1309905319.1950.48.camel@doink> MIME-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit X-Originating-IP: [128.162.232.50] X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Fri, 2011-07-01 at 05:43 -0400, Christoph Hellwig wrote: > The non-blockig behaviour in xfs_map_blocks currently is conditional on > having both the WB_SYNC_NONE sync_mode and the nonblocking flag set. > The latter used to be used by both pdflush, kswapd and a few other places > in older kernels, but has been fading out starting with the introduction > of the per-bdi flusher threads. > > Enable the non-blocking behaviour for all WB_SYNC_NONE calls to get back > the behaviour we want. The subject line should refer to xfs_vm_writepage() (not xfs_map_blocks()). Unless I hear otherwise I will plan to change that for you. Other than that this looks OK to me. Signed-off-by: Alex Elder > Signed-off-by: Christoph Hellwig