X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p663av0k063779 for ; Tue, 5 Jul 2011 22:36:57 -0500 Received: from cas.corp.sgi.com (pv-excas2-dc21-nlb.corp.sgi.com [137.38.102.197]) by relay1.corp.sgi.com (Postfix) with ESMTP id 641508F8039; Tue, 5 Jul 2011 20:36:54 -0700 (PDT) Received: from [127.0.0.1] (198.149.20.12) by xmail.sgi.com (137.38.102.30) with Microsoft SMTP Server (TLS) id 14.1.289.1; Tue, 5 Jul 2011 22:36:54 -0500 Subject: Re: [PATCH 16/27] xfs: avoid usage of struct xfs_dir2_block From: Alex Elder Reply-To: To: Christoph Hellwig CC: In-Reply-To: <20110701094605.621819832@bombadil.infradead.org> References: <20110701094321.936534538@bombadil.infradead.org> <20110701094605.621819832@bombadil.infradead.org> Content-Type: text/plain; charset="UTF-8" Date: Tue, 5 Jul 2011 22:36:53 -0500 Message-ID: <1309923413.3381.31.camel@doink> MIME-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit X-Originating-IP: [198.149.20.12] X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Fri, 2011-07-01 at 05:43 -0400, Christoph Hellwig wrote: > In most places we can simply pass around and use the struct xfs_dir2_data_hdr, > which is the first and most important member of struct xfs_dir2_block instead > of the full structure. > > Signed-off-by: Christoph Hellwig Looks good. Reviewed-by: Alex Elder