X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q1HHmHA1100002 for ; Fri, 17 Feb 2012 11:48:17 -0600 X-ASG-Debug-ID: 1329500895-04bdf002cd63230001-NocioJ Received: from bombadil.infradead.org (173-166-109-252-newengland.hfc.comcastbusiness.net [173.166.109.252]) by cuda.sgi.com with ESMTP id G3Ypw58MZPimjN1A (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Fri, 17 Feb 2012 09:48:15 -0800 (PST) X-Barracuda-Envelope-From: BATV+630a4b851243e3b20166+3099+infradead.org+hch@bombadil.srs.infradead.org X-Barracuda-Apparent-Source-IP: 173.166.109.252 Received: from hch by bombadil.infradead.org with local (Exim 4.76 #1 (Red Hat Linux)) id 1RyRuo-00025j-Qh; Fri, 17 Feb 2012 17:48:14 +0000 Date: Fri, 17 Feb 2012 12:48:14 -0500 From: Christoph Hellwig To: Dave Chinner Cc: xfs@oss.sgi.com Subject: Re: [PATCH 4/9] xfs: use per-CPU data for the quota statistics Message-ID: <20120217174814.GE21796@infradead.org> X-ASG-Orig-Subj: Re: [PATCH 4/9] xfs: use per-CPU data for the quota statistics References: <20120215022926.577682146@bombadil.infradead.org> <20120215023147.414783335@bombadil.infradead.org> <20120215235929.GP14132@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120215235929.GP14132@dastard> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-Barracuda-Connect: 173-166-109-252-newengland.hfc.comcastbusiness.net[173.166.109.252] X-Barracuda-Start-Time: 1329500895 X-Barracuda-Encrypted: AES256-SHA X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.10 X-Barracuda-Spam-Status: No, SCORE=0.10 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=1.3 tests=RDNS_DYNAMIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.88776 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.10 RDNS_DYNAMIC Delivered to trusted network by host with dynamic-looking rDNS On Thu, Feb 16, 2012 at 10:59:29AM +1100, Dave Chinner wrote: > Why not just make val a 64bit value so overflow is simply not an > issue? It's a 1:1 copy an paste from the normal XFS stats. But thinking about this copy and paste is bad - I'll rework this to add the quota stats that we keep into the normal XFS stats, and just provide the two old quota stats files as legacy views into them. That way we'll have only a single copy of that code.