Message-ID: <4F319BB8.7020808@sgi.com>
Date: Tue, 07 Feb 2012 15:46:32 -0600
From: Kevan Rehm <kfr@sgi.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.17) Gecko/20110414 SUSE/3.1.10 Lightning/1.0b2 Thunderbird/3.1.10
MIME-Version: 1.0
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/8] xfsprogs: xfs_repair: don't set the root inode pointer
References: <3ed89446f6dc1231ec1de712f242522052952b7e.1320955675.git.aelder@sgi.com> <6833e89ecf7daa3ba69676fb98a4538ee6c3a1b5.1320955675.git.aelder@sgi.com> <20111113120133.GC19435@infradead.org> <20120207183830.GA31143@infradead.org> <4F3188BF.4030403@sgi.com>
In-Reply-To: <4F3188BF.4030403@sgi.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Signed-off-by: Kevan Rehm<kfr@sgi.com>

I guess this is the proper way, sorry.

Kevan

On 02/07/2012 02:25 PM, Kevan Rehm wrote:
> On 02/07/2012 12:38 PM, Christoph Hellwig wrote:
>> On Sun, Nov 13, 2011 at 07:01:33AM -0500, Christoph Hellwig wrote:
>>> On Thu, Nov 10, 2011 at 02:35:13PM -0600, Alex Elder wrote:
>>>> From: Kevan Rehm<kfr@sgi.com>
>>>>
>>>> In phase 6, in mk_root_dir(), xfs_repair initializes the mount
>>>> point's m_rootip pointer without accounting for that reference.
>>>> This field never really used or needed in repair otherwise, and the
>>>> assigned pointer doesn't really represent a real reference to an
>>>> inode that needs to be cached.  So just kill off this assignment.
>>>>
>>>> Signed-off-by: Alex Elder<aelder@sgi.com>
>>> Shouldn't this also have Kevan's signoff?
>> Kevan, can you give me a signoff for this patch, I'd like to put it in?
>>
> Fine by me.
>
> Kevan