X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q2ODlXak029212 for ; Sat, 24 Mar 2012 08:47:33 -0500 X-ASG-Debug-ID: 1332596851-04bdf04a9d45dac0001-NocioJ Received: from bombadil.infradead.org (173-166-109-252-newengland.hfc.comcastbusiness.net [173.166.109.252]) by cuda.sgi.com with ESMTP id WpPmi6C1RPQnj0FF (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Sat, 24 Mar 2012 06:47:32 -0700 (PDT) X-Barracuda-Envelope-From: BATV+ad309bf9b63c677c6a53+3135+infradead.org+hch@bombadil.srs.infradead.org X-Barracuda-Apparent-Source-IP: 173.166.109.252 Received: from hch by bombadil.infradead.org with local (Exim 4.76 #1 (Red Hat Linux)) id 1SBRJa-0001DS-UG; Sat, 24 Mar 2012 13:47:30 +0000 Date: Sat, 24 Mar 2012 09:47:30 -0400 From: Christoph Hellwig To: Dave Chinner Cc: Christoph Hellwig , xfs@oss.sgi.com Subject: Re: [PATCH 2/4] xfs: remove log item from AIL in xfs_iflush after a shutdown Message-ID: <20120324134730.GA4674@infradead.org> X-ASG-Orig-Subj: Re: [PATCH 2/4] xfs: remove log item from AIL in xfs_iflush after a shutdown References: <20120316175541.258282540@bombadil.infradead.org> <20120316175636.187265302@bombadil.infradead.org> <20120321232029.GZ5091@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120321232029.GZ5091@dastard> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-Barracuda-Connect: 173-166-109-252-newengland.hfc.comcastbusiness.net[173.166.109.252] X-Barracuda-Start-Time: 1332596851 X-Barracuda-Encrypted: AES256-SHA X-Barracuda-URL: http://192.48.157.11:80/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at sgi.com X-Barracuda-Spam-Score: 0.10 X-Barracuda-Spam-Status: No, SCORE=0.10 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=1.3 tests=RDNS_DYNAMIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.92112 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.10 RDNS_DYNAMIC Delivered to trusted network by host with dynamic-looking rDNS On Thu, Mar 22, 2012 at 10:20:29AM +1100, Dave Chinner wrote: > > Signed-off-by: Christoph Hellwig > > Looks OK, but I'm just not sure that all the necessary places to > remove the inode from the AIL have been found. How did you find > them, and how can we validate them? We flush all inodes during either an unmount of also periodically, so we'll git it there eventually.